The Message Signaled Interrupts (MSI) support has been introduced in
UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
msi-parent property that point to the hardware entity which serves as
the MSI controller for this UFS controller.
Signed-off-by: Ziqi Chen <[email protected]>
V2 -> V3: Wrap commit message to meet Linux coding style.
V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
incorporate the details about when MCQ/MSI got introduced.
---
Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index 985ea8f..31fe7f3 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -87,6 +87,8 @@ properties:
description:
Specifies max. load that can be drawn from VCCQ2 supply.
+ msi-parent: true
+
dependencies:
freq-table-hz: [ clocks ]
operating-points-v2: [ clocks, clock-names ]
--
2.7.4
On Mon, Nov 27, 2023 at 01:36:02PM +0800, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) support has been introduced in
> UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> msi-parent property that point to the hardware entity which serves as
> the MSI controller for this UFS controller.
>
> Signed-off-by: Ziqi Chen <[email protected]>
>
> V2 -> V3: Wrap commit message to meet Linux coding style.
> V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
> incorporate the details about when MCQ/MSI got introduced.
This should be below the --- line FYI. With that fixed,
Acked-by: Conor Dooley <[email protected]>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index 985ea8f..31fe7f3 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -87,6 +87,8 @@ properties:
> description:
> Specifies max. load that can be drawn from VCCQ2 supply.
>
> + msi-parent: true
> +
> dependencies:
> freq-table-hz: [ clocks ]
> operating-points-v2: [ clocks, clock-names ]
> --
> 2.7.4
>
On Mon, Nov 27, 2023 at 05:40:45PM +0000, Conor Dooley wrote:
> On Mon, Nov 27, 2023 at 01:36:02PM +0800, Ziqi Chen wrote:
> > The Message Signaled Interrupts (MSI) support has been introduced in
> > UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> > approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> > msi-parent property that point to the hardware entity which serves as
> > the MSI controller for this UFS controller.
> >
> > Signed-off-by: Ziqi Chen <[email protected]>
> >
>
> > V2 -> V3: Wrap commit message to meet Linux coding style.
> > V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
> > incorporate the details about when MCQ/MSI got introduced.
>
> This should be below the --- line FYI. With that fixed,
> Acked-by: Conor Dooley <[email protected]>
Also, you omitted an ack from Krzysztof in
<[email protected]>
Cheers,
Conor.