2023-11-27 12:32:45

by Bard Liao

Subject: [PATCH] soundwire: generic_bandwidth_allocation use bus->params.max_dr_freq

bus->params.max_dr_freq is calculated and set in sdw_bus_master_add().
We can use it directly instead of calculating it again.

Signed-off-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Rander Wang <[email protected]>
---
drivers/soundwire/generic_bandwidth_allocation.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
index 31162f2b5638..c70a63d009ae 100644
--- a/drivers/soundwire/generic_bandwidth_allocation.c
+++ b/drivers/soundwire/generic_bandwidth_allocation.c
@@ -333,7 +333,7 @@ static int sdw_select_row_col(struct sdw_bus *bus, int clk_freq)
*/
static int sdw_compute_bus_params(struct sdw_bus *bus)
{
- unsigned int max_dr_freq, curr_dr_freq = 0;
+ unsigned int curr_dr_freq = 0;
struct sdw_master_prop *mstr_prop = &bus->prop;
int i, clk_values, ret;
bool is_gear = false;
@@ -351,14 +351,12 @@ static int sdw_compute_bus_params(struct sdw_bus *bus)
clk_buf = NULL;
}

- max_dr_freq = mstr_prop->max_clk_freq * SDW_DOUBLE_RATE_FACTOR;
-
for (i = 0; i < clk_values; i++) {
if (!clk_buf)
- curr_dr_freq = max_dr_freq;
+ curr_dr_freq = bus->params.max_dr_freq;
else
curr_dr_freq = (is_gear) ?
- (max_dr_freq >> clk_buf[i]) :
+ (bus->params.max_dr_freq >> clk_buf[i]) :
clk_buf[i] * SDW_DOUBLE_RATE_FACTOR;

if (curr_dr_freq <= bus->params.bandwidth)
--
2.25.1

2023-11-28 10:01:46

by Vinod Koul

Subject: Re: [PATCH] soundwire: generic_bandwidth_allocation use bus->params.max_dr_freq

On Mon, 27 Nov 2023 20:44:05 +0800, Bard Liao wrote:
> bus->params.max_dr_freq is calculated and set in sdw_bus_master_add().
> We can use it directly instead of calculating it again.
>
>

Applied, thanks!

[1/1] soundwire: generic_bandwidth_allocation use bus->params.max_dr_freq
commit: 55d50ace6b88eb273a10963160cadbadccfcdd64

Best regards,
--
~Vinod