2023-11-22 22:44:17

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes

The compatible schema can be simplified to a single enum for all the cases
with "fsl,imx51-src" fallback compatible.

In addition, the compatible strings are redundantly quoted. Drop unneeded
quotes over simple string values to fix a soon to be enabled yamllint
warning:

[error] string value is redundantly quoted with any quotes (quoted-strings)

Signed-off-by: Rob Herring <[email protected]>
---
.../bindings/reset/fsl,imx-src.yaml | 31 ++++++-------------
1 file changed, 10 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
index b11ac533f914..f5ec1d54aa51 100644
--- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
+++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
@@ -28,28 +28,17 @@ description: |
properties:
compatible:
oneOf:
- - const: "fsl,imx51-src"
+ - const: fsl,imx51-src
- items:
- - const: "fsl,imx50-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx53-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6q-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6sx-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6sl-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6ul-src"
- - const: "fsl,imx51-src"
- - items:
- - const: "fsl,imx6sll-src"
- - const: "fsl,imx51-src"
+ - enum:
+ - fsl,imx50-src
+ - fsl,imx53-src
+ - fsl,imx6q-src
+ - fsl,imx6sx-src
+ - fsl,imx6sl-src
+ - fsl,imx6ul-src
+ - fsl,imx6sll-src
+ - const: fsl,imx51-src

reg:
maxItems: 1
--
2.42.0

2023-11-23 07:27:05

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes

On 22/11/2023 23:44, Rob Herring wrote:
> The compatible schema can be simplified to a single enum for all the cases
> with "fsl,imx51-src" fallback compatible.
>
> In addition, the compatible strings are redundantly quoted. Drop unneeded
> quotes over simple string values to fix a soon to be enabled yamllint
> warning:
>
> [error] string value is redundantly quoted with any quotes (quoted-strings)
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-11-29 11:51:08

by Philipp Zabel

Subject: Re: [PATCH] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes

On Wed, 22 Nov 2023 15:44:04 -0700, Rob Herring wrote:
> The compatible schema can be simplified to a single enum for all the cases
> with "fsl,imx51-src" fallback compatible.
>
> In addition, the compatible strings are redundantly quoted. Drop unneeded
> quotes over simple string values to fix a soon to be enabled yamllint
> warning:
>
> [...]

Applied to reset/next, thanks!

[1/1] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes
https://git.pengutronix.de/cgit/pza/linux/commit/?id=e4916e791fb6

regards
Philipp