2023-10-12 16:06:47

by Abel Vesa

Subject: [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset

According to documentation, it has increments of 4, not 8.

Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
Reported-by: Unnathi Chalicheemala <[email protected]>
Reviewed-by: Satya Durga Srinivasu Prabhala <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Abel Vesa <[email protected]>
---

Changes since v1:
* fixed Unnathi's first name typo
* added Konrad's and Satya's R-b tags

drivers/soc/qcom/llcc-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 674abd0d6700..fb4085b7cb19 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -47,7 +47,7 @@
#define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
#define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
#define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
-#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
+#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)

#define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
#define LLCC_TRP_PCB_ACT 0x21f04
--
2.34.1

2023-12-03 04:51:57

by Bjorn Andersson

Subject: Re: [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset

On Thu, 12 Oct 2023 19:05:09 +0300, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
>

Applied, thanks!

[1/1] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
commit: 03970d2fa35497d5a5812d67ce94ca5836335159

Best regards,
--
Bjorn Andersson <[email protected]>