2023-12-08 03:33:44

by Kunwu Chan

Subject: [PATCH v2] mfd: tps6594: Add null pointer check to tps6594_device_init

devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 325bec7157b3 ("mfd: tps6594: Add driver for TI TPS6594 PMIC")
Suggested-by: Lee Jones <[email protected]>
Cc: Kunwu Chan <[email protected]>
Signed-off-by: Kunwu Chan <[email protected]>
---
v2
- Simplified by returning error codes directly
---
drivers/mfd/tps6594-core.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/tps6594-core.c b/drivers/mfd/tps6594-core.c
index 0fb9c5cf213a..783ee59901e8 100644
--- a/drivers/mfd/tps6594-core.c
+++ b/drivers/mfd/tps6594-core.c
@@ -433,6 +433,9 @@ int tps6594_device_init(struct tps6594 *tps, bool enable_crc)
tps6594_irq_chip.name = devm_kasprintf(dev, GFP_KERNEL, "%s-%ld-0x%02x",
dev->driver->name, tps->chip_id, tps->reg);

+ if (!tps6594_irq_chip.name)
+ return -ENOMEM;
+
ret = devm_regmap_add_irq_chip(dev, tps->regmap, tps->irq, IRQF_SHARED | IRQF_ONESHOT,
0, &tps6594_irq_chip, &tps->irq_data);
if (ret)
--
2.39.2

2023-12-13 15:54:04

by Lee Jones

Subject: Re: (subset) [PATCH v2] mfd: tps6594: Add null pointer check to tps6594_device_init

On Fri, 08 Dec 2023 11:33:20 +0800, Kunwu Chan wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
>
>

Applied, thanks!

[1/1] mfd: tps6594: Add null pointer check to tps6594_device_init
commit: 825906f2ebe83977d747d8bce61675dddd72485d

--
Lee Jones [李琼斯]