2023-12-01 23:03:28

by Jaegeuk Kim

Subject: [PATCH] f2fs: allow checkpoint=disable for zoned block device

Let's allow checkpoint=disable back for zoned block device. It's very risky
as the feature relies on fsck or runtime recovery which matches the write
pointers again if the device rebooted while disabling the checkpoint.

Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/super.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 033af907c3b1..617340e9ea7f 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1422,11 +1422,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
}
}

- if (test_opt(sbi, DISABLE_CHECKPOINT) && f2fs_lfs_mode(sbi)) {
- f2fs_err(sbi, "LFS is not compatible with checkpoint=disable");
- return -EINVAL;
- }
-
if (test_opt(sbi, ATGC) && f2fs_lfs_mode(sbi)) {
f2fs_err(sbi, "LFS is not compatible with ATGC");
return -EINVAL;
--
2.43.0.rc2.451.g8631bc7472-goog

2023-12-14 20:50:55

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: allow checkpoint=disable for zoned block device

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Fri, 1 Dec 2023 15:02:56 -0800 you wrote:
> Let's allow checkpoint=disable back for zoned block device. It's very risky
> as the feature relies on fsck or runtime recovery which matches the write
> pointers again if the device rebooted while disabling the checkpoint.
>
> Signed-off-by: Jaegeuk Kim <[email protected]>
> ---
> fs/f2fs/super.c | 5 -----
> 1 file changed, 5 deletions(-)

Here is the summary with links:
- [f2fs-dev] f2fs: allow checkpoint=disable for zoned block device
https://git.kernel.org/jaegeuk/f2fs/c/29215a7d43c7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html