2023-12-05 08:13:03

by Abel Vesa

[permalink] [raw]
Subject: [PATCH] soc: qcom: llcc: Add missing description for members in slice config

Fix all warnings thrown due to missing description for some of the
members in llcc_slice_config.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Abel Vesa <[email protected]>
---
drivers/soc/qcom/llcc-qcom.c | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index fb4085b7cb19..76157e3a96b2 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -92,6 +92,19 @@
* @write_scid_en: Bit enables write cache support for a given scid.
* @write_scid_cacheable_en: Enables write cache cacheable support for a
* given scid (not supported on v2 or older hardware).
+ * @stale_en: Bit enables stale.
+ * @stale_cap_en: Bit enables stale only if current scid is over-cap.
+ * @mru_uncap_en: Roll-over on reserved cache ways if current scid is
+ * under-cap.
+ * @mru_rollover: Roll-over on reserved cache ways.
+ * @alloc_oneway_en: Allways allocate one way on over-cap even if there's no
+ * same-scid lines for replacement.
+ * @ovcap_en: Once current scid is over-capacity, allocate other over-cap SCID.
+ * @ovcap_prio: Once current scid is over-capacity, allocate other low priority
+ * over-cap scid. Depends on corresponding bit being set in
+ * ovcap_en.
+ * @vict_prio: When current scid is under-capacity, allocate over other
+ * lower-than victim priority-line threshold scid.
*/
struct llcc_slice_config {
u32 usecase_id;

---
base-commit: 0f5f12ac05f36f117e793656c3f560625e927f1b
change-id: 20231205-llcc-fix-slice-config-warnings-c02a11832272

Best regards,
--
Abel Vesa <[email protected]>


2023-12-17 17:22:11

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] soc: qcom: llcc: Add missing description for members in slice config


On Tue, 05 Dec 2023 10:10:29 +0200, Abel Vesa wrote:
> Fix all warnings thrown due to missing description for some of the
> members in llcc_slice_config.
>
>

Applied, thanks!

[1/1] soc: qcom: llcc: Add missing description for members in slice config
commit: fd4b634f9b9b3dc059cf1c0ff243711bb245c004

Best regards,
--
Bjorn Andersson <[email protected]>