2023-12-18 07:07:03

by Lai Peter Jun Ann

Subject: [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt

The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN
flag is set.

Signed-off-by: Song Yoong Siang <[email protected]>
Signed-off-by: Lai Peter Jun Ann <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
index 540f6a4..f05bd75 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
@@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv)
*/
ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS);

- if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)
+ if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN))
return;

num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >>
--
1.9.1

2023-12-18 11:44:23

by Suman Ghosh

Subject: RE: [EXT] [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt

>----------------------------------------------------------------------
>The driver should continue get the timestamp if
>STMMAC_FLAG_EXT_SNAPSHOT_EN flag is set.
>
[Suman] Hi Lai,
Please ad the "fixes" tag

>Signed-off-by: Song Yoong Siang <[email protected]>
>Signed-off-by: Lai Peter Jun Ann <[email protected]>