2023-12-11 17:24:34

by Manivannan Sadhasivam

Subject: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY

While convering the binding to new format, serdes address specified in the
old binding was used as the base address. This causes a boot hang as the
driver tries to access memory region outside of the specified address. Fix
it!

Cc: Dmitry Baryshkov <[email protected]>
Cc: [email protected] # 6.6
Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
Signed-off-by: Manivannan Sadhasivam <[email protected]>
---
arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
index 2aa5089a8513..a88f186fcf03 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
@@ -436,9 +436,9 @@ pcie_ep: pcie-ep@1c00000 {
status = "disabled";
};

- pcie_phy: phy@1c07000 {
+ pcie_phy: phy@1c06000 {
compatible = "qcom,sdx55-qmp-pcie-phy";
- reg = <0x01c07000 0x2000>;
+ reg = <0x01c06000 0x2000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
--
2.25.1

2023-12-11 17:26:58

by Konrad Dybcio

Subject: Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY

On 11.12.2023 18:24, Manivannan Sadhasivam wrote:
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
> Cc: Dmitry Baryshkov <[email protected]>
> Cc: [email protected] # 6.6
> Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-12-11 17:39:45

by Dmitry Baryshkov

Subject: Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY

On Mon, 11 Dec 2023 at 19:24, Manivannan Sadhasivam
<[email protected]> wrote:
>
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
> Cc: Dmitry Baryshkov <[email protected]>
> Cc: [email protected] # 6.6
> Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
> Signed-off-by: Manivannan Sadhasivam <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

> ---
> arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> index 2aa5089a8513..a88f186fcf03 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> @@ -436,9 +436,9 @@ pcie_ep: pcie-ep@1c00000 {
> status = "disabled";
> };
>
> - pcie_phy: phy@1c07000 {
> + pcie_phy: phy@1c06000 {
> compatible = "qcom,sdx55-qmp-pcie-phy";
> - reg = <0x01c07000 0x2000>;
> + reg = <0x01c06000 0x2000>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
> --
> 2.25.1
>


--
With best wishes
Dmitry

2023-12-19 19:35:43

by Bjorn Andersson

Subject: Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY

On Mon, 11 Dec 2023 22:54:11 +0530, Manivannan Sadhasivam wrote:
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
>

Applied, thanks!

[1/1] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY
commit: cc6fc55c7ae04ab19b3972f78d3a8b1be32bf533

Best regards,
--
Bjorn Andersson <[email protected]>