2023-11-27 03:08:24

by Kunwu Chan

Subject: [PATCH] powerpc/powernv: Add a null pointer check in opal_event_init

kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 2717a33d6074 ("powerpc/opal-irqchip: Use interrupt names if present")
Signed-off-by: Kunwu Chan <[email protected]>
---
arch/powerpc/platforms/powernv/opal-irqchip.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c
index f9a7001dacb7..56a1f7ce78d2 100644
--- a/arch/powerpc/platforms/powernv/opal-irqchip.c
+++ b/arch/powerpc/platforms/powernv/opal-irqchip.c
@@ -275,6 +275,8 @@ int __init opal_event_init(void)
else
name = kasprintf(GFP_KERNEL, "opal");

+ if (!name)
+ continue;
/* Install interrupt handler */
rc = request_irq(r->start, opal_interrupt, r->flags & IRQD_TRIGGER_MASK,
name, NULL);
--
2.34.1

2023-12-21 10:42:08

by Michael Ellerman

Subject: Re: [PATCH] powerpc/powernv: Add a null pointer check in opal_event_init

On Mon, 27 Nov 2023 11:07:55 +0800, Kunwu Chan wrote:
> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
>
>

Applied to powerpc/next.

[1/1] powerpc/powernv: Add a null pointer check in opal_event_init
https://git.kernel.org/powerpc/c/8649829a1dd25199bbf557b2621cedb4bf9b3050

cheers