2023-12-18 06:08:50

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] dmaengine: std_dma40: fix kernel-doc warnings and spelling

Correct kernel-doc warnings as reported by kernel test robot:

ste_dma40.c:57: warning: Excess struct member 'dev_tx' description in 'stedma40_platform_data'
ste_dma40.c:57: warning: Excess struct member 'dev_rx' description in 'stedma40_platform_data'

Correct spellos as reported by codespell.

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Cc: Linus Walleij <[email protected]>
Cc: [email protected]
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
---
drivers/dma/ste_dma40.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff -- a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -31,13 +31,11 @@
/**
* struct stedma40_platform_data - Configuration struct for the dma device.
*
- * @dev_tx: mapping between destination event line and io address
- * @dev_rx: mapping between source event line and io address
* @disabled_channels: A vector, ending with -1, that marks physical channels
* that are for different reasons not available for the driver.
* @soft_lli_chans: A vector, that marks physical channels will use LLI by SW
* which avoids HW bug that exists in some versions of the controller.
- * SoftLLI introduces relink overhead that could impact performace for
+ * SoftLLI introduces relink overhead that could impact performance for
* certain use cases.
* @num_of_soft_lli_chans: The number of channels that needs to be configured
* to use SoftLLI.
@@ -184,7 +182,7 @@ static __maybe_unused u32 d40_backup_reg

/*
* since 9540 and 8540 has the same HW revision
- * use v4a for 9540 or ealier
+ * use v4a for 9540 or earlier
* use v4b for 8540 or later
* HW revision:
* DB8500ed has revision 0
@@ -411,7 +409,7 @@ struct d40_desc {
*
* @base: The virtual address of LCLA. 18 bit aligned.
* @dma_addr: DMA address, if mapped
- * @base_unaligned: The orignal kmalloc pointer, if kmalloc is used.
+ * @base_unaligned: The original kmalloc pointer, if kmalloc is used.
* This pointer is only there for clean-up on error.
* @pages: The number of pages needed for all physical channels.
* Only used later for clean-up on error
@@ -1655,7 +1653,7 @@ static void dma_tasklet(struct tasklet_s

return;
check_pending_tx:
- /* Rescue manouver if receiving double interrupts */
+ /* Rescue maneuver if receiving double interrupts */
if (d40c->pending_tx > 0)
d40c->pending_tx--;
spin_unlock_irqrestore(&d40c->lock, flags);
@@ -3412,7 +3410,7 @@ static int __init d40_lcla_allocate(stru
base->lcla_pool.base = (void *)page_list[i];
} else {
/*
- * After many attempts and no succees with finding the correct
+ * After many attempts and no success with finding the correct
* alignment, try with allocating a big buffer.
*/
dev_warn(base->dev,


2023-12-20 11:35:51

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: std_dma40: fix kernel-doc warnings and spelling

On Mon, Dec 18, 2023 at 7:08 AM Randy Dunlap <[email protected]> wrote:

> Correct kernel-doc warnings as reported by kernel test robot:
>
> ste_dma40.c:57: warning: Excess struct member 'dev_tx' description in 'stedma40_platform_data'
> ste_dma40.c:57: warning: Excess struct member 'dev_rx' description in 'stedma40_platform_data'
>
> Correct spellos as reported by codespell.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Cc: Linus Walleij <[email protected]>
> Cc: [email protected]
> Cc: Vinod Koul <[email protected]>
> Cc: [email protected]

Thans Randy!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-12-21 16:30:34

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: std_dma40: fix kernel-doc warnings and spelling


On Sun, 17 Dec 2023 22:08:34 -0800, Randy Dunlap wrote:
> Correct kernel-doc warnings as reported by kernel test robot:
>
> ste_dma40.c:57: warning: Excess struct member 'dev_tx' description in 'stedma40_platform_data'
> ste_dma40.c:57: warning: Excess struct member 'dev_rx' description in 'stedma40_platform_data'
>
> Correct spellos as reported by codespell.
>
> [...]

Applied, thanks!

[1/1] dmaengine: std_dma40: fix kernel-doc warnings and spelling
commit: 71a5197e2b872afeef8ade3099ffc4050466b542

Best regards,
--
~Vinod