2024-01-19 07:45:56

by Pandey, Radhey Shyam

[permalink] [raw]
Subject: [PATCH] dt-bindings: dmaengine: xilinx_dma: Remove DMA client binding

From: Abin Joseph <[email protected]>

It is not required to document dma consumer binding and its
example inside dma producer binding, so remove it.

Signed-off-by: Abin Joseph <[email protected]>
Signed-off-by: Radhey Shyam Pandey <[email protected]>
---
I am working on txt to yaml binding conversion and will send out
as followup patch.
---
.../bindings/dma/xilinx/xilinx_dma.txt | 23 -------------------
1 file changed, 23 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
index 590d1948f202..b567107270cb 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
@@ -109,26 +109,3 @@ axi_vdma_0: axivdma@40030000 {
xlnx,datawidth = <0x40>;
} ;
} ;
-
-
-* DMA client
-
-Required properties:
-- dmas: a list of <[Video DMA device phandle] [Channel ID]> pairs,
- where Channel ID is '0' for write/tx and '1' for read/rx
- channel. For MCMDA, MM2S channel(write/tx) ID start from
- '0' and is in [0-15] range. S2MM channel(read/rx) ID start
- from '16' and is in [16-31] range. These channels ID are
- fixed irrespective of IP configuration.
-
-- dma-names: a list of DMA channel names, one per "dmas" entry
-
-Example:
-++++++++
-
-vdmatest_0: vdmatest@0 {
- compatible ="xlnx,axi-vdma-test-1.00.a";
- dmas = <&axi_vdma_0 0
- &axi_vdma_0 1>;
- dma-names = "vdma0", "vdma1";
-} ;
--
2.34.1



2024-01-30 18:00:21

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: dmaengine: xilinx_dma: Remove DMA client binding

On Fri, Jan 19, 2024 at 01:14:30PM +0530, Radhey Shyam Pandey wrote:
> From: Abin Joseph <[email protected]>
>
> It is not required to document dma consumer binding and its
> example inside dma producer binding, so remove it.
>
> Signed-off-by: Abin Joseph <[email protected]>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> ---
> I am working on txt to yaml binding conversion and will send out
> as followup patch.

It is fine to just drop this in the conversion, but either way.

Acked-by: Rob Herring <[email protected]>

> ---
> .../bindings/dma/xilinx/xilinx_dma.txt | 23 -------------------
> 1 file changed, 23 deletions(-)