2024-01-09 15:01:45

by Cristian Marussi

Subject: [PATCH] firmware: arm_scmi: Fix Clock protocol version for v3.2

Enable SCMI v3.2 Clock protocol features only when Clock protocol version
equals 0x30000.

Fixes: e49e314a2cf7 ("firmware: arm_scmi: Add clock v3.2 CONFIG_SET support")
Signed-off-by: Cristian Marussi <[email protected]>
---
drivers/firmware/arm_scmi/clock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
index aaa903a41273..c22b974a3e90 100644
--- a/drivers/firmware/arm_scmi/clock.c
+++ b/drivers/firmware/arm_scmi/clock.c
@@ -1008,8 +1008,7 @@ static int scmi_clock_protocol_init(const struct scmi_protocol_handle *ph)
scmi_clock_describe_rates_get(ph, clkid, clk);
}

- if (PROTOCOL_REV_MAJOR(version) >= 0x2 &&
- PROTOCOL_REV_MINOR(version) >= 0x1) {
+ if (PROTOCOL_REV_MAJOR(version) >= 0x3) {
cinfo->clock_config_set = scmi_clock_config_set_v2;
cinfo->clock_config_get = scmi_clock_config_get_v2;
} else {
--
2.43.0

2024-01-22 14:42:39

by Sudeep Holla

Subject: Re: [PATCH] firmware: arm_scmi: Fix Clock protocol version for v3.2

On Tue, 09 Jan 2024 15:01:06 +0000, Cristian Marussi wrote:
> Enable SCMI v3.2 Clock protocol features only when Clock protocol version
> equals 0x30000.
>

Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!

[1/1] firmware: arm_scmi: Fix Clock protocol version for v3.2
https://git.kernel.org/sudeep.holla/c/27600c96e2ff
--
Regards,
Sudeep