2024-01-23 19:43:14

by Breno Leitao

[permalink] [raw]
Subject: [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2)

There are hundreds of network modules that misses MODULE_DESCRIPTION(),
causing a warnning when compiling with W=1. Example:

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o

This part2 of the patchset focus on the drivers/net/ethernet drivers.
There are still some missing warnings in drivers/net/ethernet that will
be fixed in an upcoming patchset.

Changelog:
---------
V1:
* https://lore.kernel.org/all/[email protected]/

V2:
* Limit the patchset to 10 patches.
* Rewrite the following module description:
* fec
* bgmac
* Added acknowledge in the following driver:
* litex

Breno Leitao (10):
net: fill in MODULE_DESCRIPTION()s for 8390
net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac
net: fill in MODULE_DESCRIPTION()s for liquidio
net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth
net: fill in MODULE_DESCRIPTION()s for nps_enet
net: fill in MODULE_DESCRIPTION()s for enetc
net: fill in MODULE_DESCRIPTION()s for fec
net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio
net: fill in MODULE_DESCRIPTION()s for litex
net: fill in MODULE_DESCRIPTION()s for rvu_mbox

drivers/net/ethernet/8390/8390.c | 1 +
drivers/net/ethernet/8390/8390p.c | 1 +
drivers/net/ethernet/8390/apne.c | 1 +
drivers/net/ethernet/8390/hydra.c | 1 +
drivers/net/ethernet/8390/stnic.c | 1 +
drivers/net/ethernet/8390/zorro8390.c | 1 +
drivers/net/ethernet/broadcom/bcm4908_enet.c | 1 +
drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
drivers/net/ethernet/broadcom/bgmac-bcma.c | 1 +
drivers/net/ethernet/broadcom/bgmac-platform.c | 1 +
drivers/net/ethernet/broadcom/bgmac.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 +
drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 +
drivers/net/ethernet/ezchip/nps_enet.c | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 1 +
drivers/net/ethernet/freescale/fec_main.c | 1 +
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 1 +
drivers/net/ethernet/litex/litex_liteeth.c | 1 +
drivers/net/ethernet/marvell/octeontx2/af/mbox.c | 1 +
19 files changed, 19 insertions(+)

--
2.39.3



2024-01-23 19:47:13

by Breno Leitao

[permalink] [raw]
Subject: [PATCH net v2 04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Cirrus EP93xx ethernet driver.

Signed-off-by: Breno Leitao <[email protected]>
---
drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c
index 1c2a540db13d..1f495cfd7959 100644
--- a/drivers/net/ethernet/cirrus/ep93xx_eth.c
+++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c
@@ -868,5 +868,6 @@ static struct platform_driver ep93xx_eth_driver = {

module_platform_driver(ep93xx_eth_driver);

+MODULE_DESCRIPTION("Cirrus EP93xx Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:ep93xx-eth");
--
2.39.3


2024-01-23 19:47:18

by Breno Leitao

[permalink] [raw]
Subject: [PATCH net v2 06/10] net: fill in MODULE_DESCRIPTION()s for enetc

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the NXP ENETC Ethernet driver.

Signed-off-by: Breno Leitao <[email protected]>
---
drivers/net/ethernet/freescale/enetc/enetc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index cffbf27c4656..bfdbdab443ae 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -3216,4 +3216,5 @@ void enetc_pci_remove(struct pci_dev *pdev)
}
EXPORT_SYMBOL_GPL(enetc_pci_remove);

+MODULE_DESCRIPTION("NXP ENETC Ethernet driver");
MODULE_LICENSE("Dual BSD/GPL");
--
2.39.3


2024-01-23 19:48:12

by Breno Leitao

[permalink] [raw]
Subject: [PATCH net v2 09/10] net: fill in MODULE_DESCRIPTION()s for litex

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LiteX Liteeth Ethernet device.

Signed-off-by: Breno Leitao <[email protected]>
Acked-by: Gabriel Somlo <[email protected]>
---
drivers/net/ethernet/litex/litex_liteeth.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 5182fe737c37..ff54fbe41bcc 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -318,4 +318,5 @@ static struct platform_driver liteeth_driver = {
module_platform_driver(liteeth_driver);

MODULE_AUTHOR("Joel Stanley <[email protected]>");
+MODULE_DESCRIPTION("LiteX Liteeth Ethernet driver");
MODULE_LICENSE("GPL");
--
2.39.3


2024-01-24 23:21:57

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2)

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 23 Jan 2024 11:03:21 -0800 you wrote:
> There are hundreds of network modules that misses MODULE_DESCRIPTION(),
> causing a warnning when compiling with W=1. Example:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
>
> [...]

Here is the summary with links:
- [net,v2,01/10] net: fill in MODULE_DESCRIPTION()s for 8390
https://git.kernel.org/netdev/net/c/f5e414167be7
- [net,v2,02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac
https://git.kernel.org/netdev/net/c/39535d7ff6c1
- [net,v2,03/10] net: fill in MODULE_DESCRIPTION()s for liquidio
https://git.kernel.org/netdev/net/c/bb567fbbbbb4
- [net,v2,04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth
https://git.kernel.org/netdev/net/c/53c83e2d3648
- [net,v2,05/10] net: fill in MODULE_DESCRIPTION()s for nps_enet
https://git.kernel.org/netdev/net/c/27881ca8c8e1
- [net,v2,06/10] net: fill in MODULE_DESCRIPTION()s for enetc
https://git.kernel.org/netdev/net/c/07c42d237567
- [net,v2,07/10] net: fill in MODULE_DESCRIPTION()s for fec
https://git.kernel.org/netdev/net/c/2e8757648855
- [net,v2,08/10] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio
https://git.kernel.org/netdev/net/c/8183c470c176
- [net,v2,09/10] net: fill in MODULE_DESCRIPTION()s for litex
https://git.kernel.org/netdev/net/c/07d1e0ce8743
- [net,v2,10/10] net: fill in MODULE_DESCRIPTION()s for rvu_mbox
https://git.kernel.org/netdev/net/c/bdc6734115d7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html