2024-01-23 06:28:37

by Amit Pundir

Subject: [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd

With the addition of RPMh power domain to the GCC node in
device tree, we noticed a significant delay in getting the
UFS driver probed on AOSP which futher led to mount failures
because Android do not support rootwait. So adding a soft
dependency on RPMh power domain which informs modprobe to
load rpmhpd module before gcc-sdm845.

Cc: <[email protected]> # v5.4+
Fixes: 4b6ea15c0a11 ("arm64: dts: qcom: sdm845: Add missing RPMh power domain to GCC")
Suggested-by: Manivannan Sadhasivam <[email protected]>
Signed-off-by: Amit Pundir <[email protected]>
---
drivers/clk/qcom/gcc-sdm845.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c
index 725cd52d2398..ea4c3bf4fb9b 100644
--- a/drivers/clk/qcom/gcc-sdm845.c
+++ b/drivers/clk/qcom/gcc-sdm845.c
@@ -4037,3 +4037,4 @@ module_exit(gcc_sdm845_exit);
MODULE_DESCRIPTION("QTI GCC SDM845 Driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:gcc-sdm845");
+MODULE_SOFTDEP("pre: rpmhpd");
--
2.25.1

2024-01-23 09:50:46

by Manivannan Sadhasivam

Subject: Re: [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd

On Tue, Jan 23, 2024 at 11:58:14AM +0530, Amit Pundir wrote:
> With the addition of RPMh power domain to the GCC node in
> device tree, we noticed a significant delay in getting the
> UFS driver probed on AOSP which futher led to mount failures
> because Android do not support rootwait. So adding a soft
> dependency on RPMh power domain which informs modprobe to
> load rpmhpd module before gcc-sdm845.
>
> Cc: <[email protected]> # v5.4+
> Fixes: 4b6ea15c0a11 ("arm64: dts: qcom: sdm845: Add missing RPMh power domain to GCC")
> Suggested-by: Manivannan Sadhasivam <[email protected]>
> Signed-off-by: Amit Pundir <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

- Mani

> ---
> drivers/clk/qcom/gcc-sdm845.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c
> index 725cd52d2398..ea4c3bf4fb9b 100644
> --- a/drivers/clk/qcom/gcc-sdm845.c
> +++ b/drivers/clk/qcom/gcc-sdm845.c
> @@ -4037,3 +4037,4 @@ module_exit(gcc_sdm845_exit);
> MODULE_DESCRIPTION("QTI GCC SDM845 Driver");
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:gcc-sdm845");
> +MODULE_SOFTDEP("pre: rpmhpd");
> --
> 2.25.1
>

--
மணிவண்ணன் சதாசிவம்

2024-01-27 22:36:07

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd

On Tue, 23 Jan 2024 11:58:14 +0530, Amit Pundir wrote:
> With the addition of RPMh power domain to the GCC node in
> device tree, we noticed a significant delay in getting the
> UFS driver probed on AOSP which futher led to mount failures
> because Android do not support rootwait. So adding a soft
> dependency on RPMh power domain which informs modprobe to
> load rpmhpd module before gcc-sdm845.
>
> [...]

Applied, thanks!

[1/1] clk: qcom: gcc-sdm845: Add soft dependency on rpmhpd
commit: 1d9054e3a4fd36e2949e616f7360bdb81bcc1921

Best regards,
--
Bjorn Andersson <[email protected]>