2024-01-29 18:00:48

by Aleksandr Mikhalitsyn

[permalink] [raw]
Subject: [PATCH 1/2] ntfs3: use file_mnt_idmap helper

Let's use file_mnt_idmap() as we do that across the tree.

No functional impact.

Cc: Christian Brauner <[email protected]>
Cc: Konstantin Komarov <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Signed-off-by: Alexander Mikhalitsyn <[email protected]>
---
fs/ntfs3/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
index ee3093be5170..144aa80cca43 100644
--- a/fs/ntfs3/namei.c
+++ b/fs/ntfs3/namei.c
@@ -419,7 +419,7 @@ static int ntfs_atomic_open(struct inode *dir, struct dentry *dentry,
* fnd contains tree's path to insert to.
* If fnd is not NULL then dir is locked.
*/
- inode = ntfs_create_inode(mnt_idmap(file->f_path.mnt), dir, dentry, uni,
+ inode = ntfs_create_inode(file_mnt_idmap(file), dir, dentry, uni,
mode, 0, NULL, 0, fnd);
err = IS_ERR(inode) ? PTR_ERR(inode) :
finish_open(file, dentry, ntfs_file_open);
--
2.34.1



2024-01-29 18:01:06

by Aleksandr Mikhalitsyn

[permalink] [raw]
Subject: [PATCH 2/2] io_uring: use file_mnt_idmap helper

Let's use file_mnt_idmap() as we do that across the tree.

No functional impact.

Cc: Christian Brauner <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Pavel Begunkov <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Signed-off-by: Alexander Mikhalitsyn <[email protected]>
---
io_uring/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/xattr.c b/io_uring/xattr.c
index e1c810e0b85a..44905b82eea8 100644
--- a/io_uring/xattr.c
+++ b/io_uring/xattr.c
@@ -112,7 +112,7 @@ int io_fgetxattr(struct io_kiocb *req, unsigned int issue_flags)

WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK);

- ret = do_getxattr(mnt_idmap(req->file->f_path.mnt),
+ ret = do_getxattr(file_mnt_idmap(req->file),
req->file->f_path.dentry,
&ix->ctx);

--
2.34.1


2024-01-29 21:07:20

by Jens Axboe

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] ntfs3: use file_mnt_idmap helper


On Mon, 29 Jan 2024 19:00:23 +0100, Alexander Mikhalitsyn wrote:
> Let's use file_mnt_idmap() as we do that across the tree.
>
> No functional impact.
>
>

Applied, thanks!

[2/2] io_uring: use file_mnt_idmap helper
commit: 712fc7e5862c2b9af7cf37418e4b398c5493ffb5

Best regards,
--
Jens Axboe




2024-01-30 09:41:21

by Christian Brauner

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] ntfs3: use file_mnt_idmap helper

On Mon, 29 Jan 2024 19:00:23 +0100, Alexander Mikhalitsyn wrote:
> Let's use file_mnt_idmap() as we do that across the tree.
>
> No functional impact.
>
>

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/2] ntfs3: use file_mnt_idmap helper
https://git.kernel.org/vfs/vfs/c/16a37cba65f1

2024-01-30 09:52:28

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH 2/2] io_uring: use file_mnt_idmap helper

On Mon, Jan 29, 2024 at 07:00:24PM +0100, Alexander Mikhalitsyn wrote:
> Let's use file_mnt_idmap() as we do that across the tree.
>
> No functional impact.
>
> Cc: Christian Brauner <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: Pavel Begunkov <[email protected]>
> Cc: <[email protected]>
> Cc: <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Alexander Mikhalitsyn <[email protected]>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <[email protected]>