2024-02-04 15:31:55

by Ricardo B. Marliere

Subject: [PATCH] block: rbd: make rbd_bus_type const

Now that the driver core can properly handle constant struct bus_type,
move the rbd_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 0202a4e5d6cf..21f2b9e9b9ff 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -575,7 +575,7 @@ static const struct attribute_group rbd_bus_group = {
};
__ATTRIBUTE_GROUPS(rbd_bus);

-static struct bus_type rbd_bus_type = {
+static const struct bus_type rbd_bus_type = {
.name = "rbd",
.bus_groups = rbd_bus_groups,
};

---
base-commit: aa826a9b19b93bf8aabc462381ae436a60b2a320
change-id: 20240204-bus_cleanup-block-9986bfea7975

Best regards,
--
Ricardo B. Marliere <[email protected]>

2024-02-04 21:06:51

by Alex Elder

Subject: Re: [PATCH] block: rbd: make rbd_bus_type const

On 2/4/24 9:31 AM, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Great!

Reviewed-by: Alex Elder <[email protected]>

> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 0202a4e5d6cf..21f2b9e9b9ff 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -575,7 +575,7 @@ static const struct attribute_group rbd_bus_group = {
> };
> __ATTRIBUTE_GROUPS(rbd_bus);
>
> -static struct bus_type rbd_bus_type = {
> +static const struct bus_type rbd_bus_type = {
> .name = "rbd",
> .bus_groups = rbd_bus_groups,
> };
>
> ---
> base-commit: aa826a9b19b93bf8aabc462381ae436a60b2a320
> change-id: 20240204-bus_cleanup-block-9986bfea7975
>
> Best regards,

2024-02-05 20:43:15

by Greg Kroah-Hartman

Subject: Re: [PATCH] block: rbd: make rbd_bus_type const

On Sun, Feb 04, 2024 at 12:31:42PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2024-02-06 17:39:41

by Jens Axboe

Subject: Re: [PATCH] block: rbd: make rbd_bus_type const

On Sun, 04 Feb 2024 12:31:42 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
>

Applied, thanks!

[1/1] block: rbd: make rbd_bus_type const
commit: 052618c71c66d5de5e9b6cbcbad26932d951919c

Best regards,
--
Jens Axboe