2024-02-04 16:02:13

by Ricardo B. Marliere

[permalink] [raw]
Subject: [PATCH] counter: make counter_bus_type const

Now that the driver core can properly handle constant struct bus_type,
move the counter_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/counter/counter-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/counter/counter-core.c b/drivers/counter/counter-core.c
index 09c77afb33ca..f6a939d51171 100644
--- a/drivers/counter/counter-core.c
+++ b/drivers/counter/counter-core.c
@@ -53,7 +53,7 @@ static struct device_type counter_device_type = {
.release = counter_device_release,
};

-static struct bus_type counter_bus_type = {
+static const struct bus_type counter_bus_type = {
.name = "counter",
.dev_name = "counter",
};

---
base-commit: 0b3bbd8f9baf245ec77d86f6f5bc902105b4bfa9
change-id: 20240204-bus_cleanup-counter-7ea21a4a4abd

Best regards,
--
Ricardo B. Marliere <[email protected]>



2024-02-05 20:33:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] counter: make counter_bus_type const

On Sun, Feb 04, 2024 at 01:02:30PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the counter_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2024-02-08 18:25:11

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH] counter: make counter_bus_type const


On Sun, 04 Feb 2024 13:02:30 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the counter_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
>

Applied, thanks!

[1/1] counter: make counter_bus_type const
commit: 856132743893a977fe1f1103b3f51b7f0984c2f1

William Breathitt Gray <[email protected]>