Adds support for the Atmel touchscreen to the Samsung Galaxy Express
SGH-I437. Copies the gsbi3 node from apq8064, which is a similar SoC,
and sets appropriate properties.
Applies successfully on top of my previous patch:
https://lkml.org/lkml/2024/1/20/56
Signed-off-by: Rudraksha Gupta <[email protected]>
---
Changes in v2:
- Fix formatting for gsbi3
- Link to v1: https://lore.kernel.org/r/20240129-expressatt_mxt224s_touchscreen-v1-0-fb8552e1c32c@gmail.com
---
Rudraksha Gupta (2):
ARM: dts: qcom: msm8960: Add gsbi3 node
ARM: dts: qcom: msm8960: expressatt: Add mXT224S touchscreen
arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi | 21 +++++++++++++++
.../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 31 +++++++++++++++++++++-
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 28 +++++++++++++++++++
3 files changed, 79 insertions(+), 1 deletion(-)
---
base-commit: df2fa93a6956fcd03da4c251150aa9cc3c88c74d
change-id: 20240129-expressatt_mxt224s_touchscreen-f1f4dc01667c
Best regards,
--
Rudraksha Gupta <[email protected]>
From: Rudraksha Gupta <[email protected]>
Copy gsbi3 node from qcom-apq8064.dtsi and set appropriate properties
Signed-off-by: Rudraksha Gupta <[email protected]>
---
arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi | 21 ++++++++++++++++++++
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 28 +++++++++++++++++++++++++++
2 files changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi
new file mode 100644
index 000000000000..4fa982771288
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+&msmgpio {
+ i2c3_default_state: i2c3-default-state {
+ i2c3-pins {
+ pins = "gpio16", "gpio17";
+ function = "gsbi3";
+ drive-strength = <8>;
+ bias-disable;
+ };
+ };
+
+ i2c3_sleep_state: i2c3-sleep-state {
+ i2c3-pins {
+ pins = "gpio16", "gpio17";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-bus-hold;
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index f420740e068e..93365298c5ae 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -359,5 +359,33 @@ usb_hs1_phy: phy {
};
};
};
+
+ gsbi3: gsbi@16200000 {
+ compatible = "qcom,gsbi-v1.0.0";
+ reg = <0x16200000 0x100>;
+ ranges;
+ cell-index = <3>;
+ clocks = <&gcc GSBI3_H_CLK>;
+ clock-names = "iface";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ status = "disabled";
+
+ gsbi3_i2c: i2c@16280000 {
+ compatible = "qcom,i2c-qup-v1.1.1";
+ reg = <0x16280000 0x1000>;
+ pinctrl-0 = <&i2c3_default_state>;
+ pinctrl-1 = <&i2c3_sleep_state>;
+ pinctrl-names = "default", "sleep";
+ interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GSBI3_QUP_CLK>,
+ <&gcc GSBI3_H_CLK>;
+ clock-names = "core", "iface";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+ };
};
};
+#include "qcom-msm8960-pins.dtsi"
--
2.43.0
On Wed, 31 Jan 2024 01:04:45 -0800, Rudraksha Gupta wrote:
> Adds support for the Atmel touchscreen to the Samsung Galaxy Express
> SGH-I437. Copies the gsbi3 node from apq8064, which is a similar SoC,
> and sets appropriate properties.
>
> Applies successfully on top of my previous patch:
> https://lkml.org/lkml/2024/1/20/56
>
> [...]
Applied, thanks!
[1/2] ARM: dts: qcom: msm8960: Add gsbi3 node
commit: 1cf6313648753e489ece516d05f77b39e52ff07e
[2/2] ARM: dts: qcom: msm8960: expressatt: Add mXT224S touchscreen
commit: 5936ee212525c7d1221a42e8189932cf42d35776
Best regards,
--
Bjorn Andersson <[email protected]>