2024-02-14 07:24:58

by Randy Dunlap

Subject: [PATCH] scsi: jazz_esp: only build if SCSI core is builtin

JAZZ_ESP is a bool kconfig symbol that selects SCSI_SPI_ATTRS.
When CONFIG_SCSI=m, this results in SCSI_SPI_ATTRS=m while
JAZZ_ESP=y, which causes many undefined symbol linker errors.

Fix this by only offering to build this driver when CONFIG_SCSI=y.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Cc: Thomas Bogendoerfer <[email protected]>
Cc: [email protected]
Cc: Arnd Bergmann <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Nicolas Schier <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
Cc: [email protected]
Cc: Geert Uytterhoeven <[email protected]>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1279,7 +1279,7 @@ source "drivers/scsi/arm/Kconfig"

config JAZZ_ESP
bool "MIPS JAZZ FAS216 SCSI support"
- depends on MACH_JAZZ && SCSI
+ depends on MACH_JAZZ && SCSI=y
select SCSI_SPI_ATTRS
help
This is the driver for the onboard SCSI host adapter of MIPS Magnum

2024-02-15 20:46:39

by Martin K. Petersen

Subject: Re: [PATCH] scsi: jazz_esp: only build if SCSI core is builtin

On Tue, 13 Feb 2024 21:59:53 -0800, Randy Dunlap wrote:

> JAZZ_ESP is a bool kconfig symbol that selects SCSI_SPI_ATTRS.
> When CONFIG_SCSI=m, this results in SCSI_SPI_ATTRS=m while
> JAZZ_ESP=y, which causes many undefined symbol linker errors.
>
> Fix this by only offering to build this driver when CONFIG_SCSI=y.
>
>
> [...]

Applied to 6.8/scsi-fixes, thanks!

[1/1] scsi: jazz_esp: only build if SCSI core is builtin
https://git.kernel.org/mkp/scsi/c/9ddf190a7df7

--
Martin K. Petersen Oracle Linux Engineering