2024-02-09 16:04:35

by Andy Shevchenko

Subject: [PATCH v1 0/2] phy: ti: tusb1210: a couple of cleanups

A couple of ad-hoc cleanups. Nothing special. Has been tested on
Intel Merrifield platform (with DWC3 using this PHY).

Andy Shevchenko (2):
phy: ti: tusb1210: Use temporary variable for struct device
phy: ti: tusb1210: Define device IDs

drivers/phy/ti/phy-tusb1210.c | 57 ++++++++++++++++++-----------------
1 file changed, 30 insertions(+), 27 deletions(-)

--
2.43.0.rc1.1.gbec44491f096

2024-02-09 16:04:47

by Andy Shevchenko

Subject: [PATCH v1 2/2] phy: ti: tusb1210: Define device IDs

Define device IDs since some of them are being used more than once.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/phy/ti/phy-tusb1210.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c
index 7232b104a62d..13cd614e12a1 100644
--- a/drivers/phy/ti/phy-tusb1210.c
+++ b/drivers/phy/ti/phy-tusb1210.c
@@ -17,6 +17,10 @@
#include <linux/property.h>
#include <linux/workqueue.h>

+#define TI_VENDOR_ID 0x0451
+#define TI_DEVICE_TUSB1210 0x1507
+#define TI_DEVICE_TUSB1211 0x1508
+
#define TUSB1211_POWER_CONTROL 0x3d
#define TUSB1211_POWER_CONTROL_SET 0x3e
#define TUSB1211_POWER_CONTROL_CLEAR 0x3f
@@ -436,7 +440,7 @@ static void tusb1210_probe_charger_detect(struct tusb1210 *tusb)
if (!device_property_read_bool(dev->parent, "linux,phy_charger_detect"))
return;

- if (ulpi->id.product != 0x1508) {
+ if (ulpi->id.product != TI_DEVICE_TUSB1211) {
dev_err(dev, "error charger detection is only supported on the TUSB1211\n");
return;
}
@@ -562,11 +566,9 @@ static void tusb1210_remove(struct ulpi *ulpi)
tusb1210_remove_charger_detect(tusb);
}

-#define TI_VENDOR_ID 0x0451
-
static const struct ulpi_device_id tusb1210_ulpi_id[] = {
- { TI_VENDOR_ID, 0x1507, }, /* TUSB1210 */
- { TI_VENDOR_ID, 0x1508, }, /* TUSB1211 */
+ { TI_VENDOR_ID, TI_DEVICE_TUSB1210 },
+ { TI_VENDOR_ID, TI_DEVICE_TUSB1211 },
{ },
};
MODULE_DEVICE_TABLE(ulpi, tusb1210_ulpi_id);
--
2.43.0.rc1.1.gbec44491f096

2024-02-16 11:58:28

by Vinod Koul

Subject: Re: [PATCH v1 0/2] phy: ti: tusb1210: a couple of cleanups

On Fri, 09 Feb 2024 18:02:13 +0200, Andy Shevchenko wrote:
> A couple of ad-hoc cleanups. Nothing special. Has been tested on
> Intel Merrifield platform (with DWC3 using this PHY).
>
> Andy Shevchenko (2):
> phy: ti: tusb1210: Use temporary variable for struct device
> phy: ti: tusb1210: Define device IDs
>
> [...]

Applied, thanks!

[1/2] phy: ti: tusb1210: Use temporary variable for struct device
commit: 03db1786fe9eae146ba9b3e4fd220f1e502d588b
[2/2] phy: ti: tusb1210: Define device IDs
commit: 505dfc6ba84c85651f8f8a7bf721aadc49049a44

Best regards,
--
~Vinod