2024-02-14 00:21:19

by Judith Mendez

[permalink] [raw]
Subject: [PATCH v3 0/9] Fix MMC properties on Sitara K3 devices

This patch series aims to fix and update MMC nodes for TI
Sitara K3 devices with the following changes.

The series introduces sdhci0 and sdhci2 nodes and enables
eMMC for AM62ax platform.

Also introduce fixes for MMC ITAP/OTAP values for AM64x
platform according to device datasheet [0], and add ITAP/
OTAP values for AM62p to enable the highest timing possible
for MMC0 and MMC1, according to device datasheet [1].

The DLL properties ti,trm-icp and ti,driver-strength-ohm
should be removed for soft PHYs since drive strength cannot
be changed, so remove these properties when not applicable.
Since this fix touches non-TI boards and therefore cannot be
tested, all tested-by's are welcome.

Also include a few fixes for ti,clkbuf-sel, bus-width,
and bootph-all device tree properties in MMC nodes.

This series was tested on:
- AM62a SK
- AM62x SK
- AM62p SK
- AM64x GP EVM
- AM64x SK EVM
- Beagleplay

[0] https://www.ti.com/lit/ds/symlink/am6442.pdf
[1] https://www.ti.com/lit/ds/symlink/am62p.pdf

Fixes since V2:
- Remove ti,driver-strength-ohm property in sdhci1 node for
k3-am642-tqma64xxl-mbax4xxl and k3-am642-phyboard-electra-rdk board files.
- Add Francesco's Acked-by

V2: https://lore.kernel.org/linux-devicetree/[email protected]/
V1: https://lore.kernel.org/linux-devicetree/[email protected]/
RFC: https://lore.kernel.org/linux-devicetree/[email protected]/

Judith Mendez (7):
arm64: dts: ti: k3-am62a-main: Add sdhci2 instance
arm64: dts: ti: k3-am64-main: Fix ITAP/OTAP values for MMC
arm64: dts: ti: k3-am62p: Add ITAP/OTAP values for MMC
arm64: dts: ti: k3-am6*: Remove DLL properties for soft PHYs
arm64: dts: ti: k3-am6*: Fix ti,clkbuf-sel property in MMC nodes
arm64: dts: ti: k3-am6*: Fix bus-width property in MMC nodes
arm64: dts: ti: k3-am6*: Add bootph-all property in MMC node

Nitin Yadav (2):
arm64: dts: ti: k3-am62a-main: Add sdhci0 instance
arm64: dts: ti: k3-am62a7-sk: Enable eMMC support

arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 12 +++--
.../boot/dts/ti/k3-am62-phycore-som.dtsi | 1 -
.../boot/dts/ti/k3-am62-verdin-dahlia.dtsi | 1 -
.../arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi | 1 -
.../boot/dts/ti/k3-am62-verdin-wifi.dtsi | 1 -
arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 2 -
.../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 --
.../dts/ti/k3-am625-phyboard-lyra-rdk.dts | 1 -
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 45 ++++++++++++++++++-
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 27 ++++++++++-
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 44 ++++++++++++++++--
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 3 +-
.../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 -
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 15 +++++--
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 +-
.../dts/ti/k3-am642-phyboard-electra-rdk.dts | 1 -
arch/arm64/boot/dts/ti/k3-am642-sk.dts | 2 -
.../dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts | 1 -
18 files changed, 129 insertions(+), 38 deletions(-)


base-commit: 1e6bbc5185bcd113c8d2f7aa0a02f588a6bdbe5d
--
2.43.0



2024-02-14 10:44:19

by Wadim Egorov

[permalink] [raw]
Subject: Re: [PATCH v3 0/9] Fix MMC properties on Sitara K3 devices


Am 14.02.24 um 00:56 schrieb Judith Mendez:
> This patch series aims to fix and update MMC nodes for TI
> Sitara K3 devices with the following changes.
>
> The series introduces sdhci0 and sdhci2 nodes and enables
> eMMC for AM62ax platform.
>
> Also introduce fixes for MMC ITAP/OTAP values for AM64x
> platform according to device datasheet [0], and add ITAP/
> OTAP values for AM62p to enable the highest timing possible
> for MMC0 and MMC1, according to device datasheet [1].
>
> The DLL properties ti,trm-icp and ti,driver-strength-ohm
> should be removed for soft PHYs since drive strength cannot
> be changed, so remove these properties when not applicable.
> Since this fix touches non-TI boards and therefore cannot be
> tested, all tested-by's are welcome.
>
> Also include a few fixes for ti,clkbuf-sel, bus-width,
> and bootph-all device tree properties in MMC nodes.
>
> This series was tested on:
> - AM62a SK
> - AM62x SK
> - AM62p SK
> - AM64x GP EVM
> - AM64x SK EVM
> - Beagleplay

Adding my Tested-by for the phyBOARD-Electra-AM642 board.

Tested-by: Wadim Egorov <[email protected]>


>
> [0] https://www.ti.com/lit/ds/symlink/am6442.pdf
> [1] https://www.ti.com/lit/ds/symlink/am62p.pdf
>
> Fixes since V2:
> - Remove ti,driver-strength-ohm property in sdhci1 node for
> k3-am642-tqma64xxl-mbax4xxl and k3-am642-phyboard-electra-rdk board files.
> - Add Francesco's Acked-by
>
> V2: https://lore.kernel.org/linux-devicetree/[email protected]/
> V1: https://lore.kernel.org/linux-devicetree/[email protected]/
> RFC: https://lore.kernel.org/linux-devicetree/[email protected]/
>
> Judith Mendez (7):
> arm64: dts: ti: k3-am62a-main: Add sdhci2 instance
> arm64: dts: ti: k3-am64-main: Fix ITAP/OTAP values for MMC
> arm64: dts: ti: k3-am62p: Add ITAP/OTAP values for MMC
> arm64: dts: ti: k3-am6*: Remove DLL properties for soft PHYs
> arm64: dts: ti: k3-am6*: Fix ti,clkbuf-sel property in MMC nodes
> arm64: dts: ti: k3-am6*: Fix bus-width property in MMC nodes
> arm64: dts: ti: k3-am6*: Add bootph-all property in MMC node
>
> Nitin Yadav (2):
> arm64: dts: ti: k3-am62a-main: Add sdhci0 instance
> arm64: dts: ti: k3-am62a7-sk: Enable eMMC support
>
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 12 +++--
> .../boot/dts/ti/k3-am62-phycore-som.dtsi | 1 -
> .../boot/dts/ti/k3-am62-verdin-dahlia.dtsi | 1 -
> .../arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi | 1 -
> .../boot/dts/ti/k3-am62-verdin-wifi.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 2 -
> .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 --
> .../dts/ti/k3-am625-phyboard-lyra-rdk.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 45 ++++++++++++++++++-
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 27 ++++++++++-
> arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 44 ++++++++++++++++--
> arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 3 +-
> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 -
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 15 +++++--
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 +-
> .../dts/ti/k3-am642-phyboard-electra-rdk.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 2 -
> .../dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts | 1 -
> 18 files changed, 129 insertions(+), 38 deletions(-)
>
>
> base-commit: 1e6bbc5185bcd113c8d2f7aa0a02f588a6bdbe5d

2024-02-20 04:03:55

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v3 0/9] Fix MMC properties on Sitara K3 devices

Hi Judith Mendez,

On Tue, 13 Feb 2024 17:56:52 -0600, Judith Mendez wrote:
> This patch series aims to fix and update MMC nodes for TI
> Sitara K3 devices with the following changes.
>
> The series introduces sdhci0 and sdhci2 nodes and enables
> eMMC for AM62ax platform.
>
> Also introduce fixes for MMC ITAP/OTAP values for AM64x
> platform according to device datasheet [0], and add ITAP/
> OTAP values for AM62p to enable the highest timing possible
> for MMC0 and MMC1, according to device datasheet [1].
>
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/9] arm64: dts: ti: k3-am62a-main: Add sdhci0 instance
commit: d3ae4e8d8b6ac0db82264c5576daa260cac3d536
[2/9] arm64: dts: ti: k3-am62a-main: Add sdhci2 instance
commit: feb5d68cec77b6783f4febb8c91c1b1caa8b4924
[3/9] arm64: dts: ti: k3-am62a7-sk: Enable eMMC support
commit: e041ec6e86e7dbc49f5245ace6f3b965bb7c26f7
[4/9] arm64: dts: ti: k3-am64-main: Fix ITAP/OTAP values for MMC
commit: 379c7752bbd0e81654544a896dd19c19ebb6faba
[5/9] arm64: dts: ti: k3-am62p: Add ITAP/OTAP values for MMC
commit: 37f28165518f7df2ed085e4481dade9c262b593b
[6/9] arm64: dts: ti: k3-am6*: Remove DLL properties for soft PHYs
commit: eea929f0e0e3f83d2c027b1e60630deb50df4494
[7/9] arm64: dts: ti: k3-am6*: Fix ti,clkbuf-sel property in MMC nodes
commit: 2812d23ade3d614b451bff5d63d29a31b92d8859
[8/9] arm64: dts: ti: k3-am6*: Fix bus-width property in MMC nodes
commit: 0ae3113a46a64266f19fdc9753d5e3a6748fc594
[9/9] arm64: dts: ti: k3-am6*: Add bootph-all property in MMC node
commit: 5f0e6ce354f61092182b79d177585bd7310f12a2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh