2024-02-01 20:59:10

by Frank Li

[permalink] [raw]
Subject: [PATCH v2 0/4] Add 8qm SMMU information

Change at v2
- Remove iM95 for fec.

To: Ulf Hansson <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Shawn Guo <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: NXP Linux Team <[email protected]>
To: Wei Fang <[email protected]>
To: Shenwei Wang <[email protected]>
To: Clark Wang <[email protected]>
To: David S. Miller <[email protected]>
To: Eric Dumazet <[email protected]>
To: Jakub Kicinski <[email protected]>
To: Paolo Abeni <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

Signed-off-by: Frank Li <[email protected]>
---
Frank Li (4):
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information

.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++
Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++
arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
4 files changed, 53 insertions(+)
---
base-commit: 99748ff5ee0953610765e9d0cd6015c2eb0f7ace
change-id: 20240201-8qm_smmu-6318da8e9017

Best regards,
--
Frank Li <[email protected]>



2024-02-02 19:11:17

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> dt-bindings: net: fec: add iommus property
> arm64: dts: imx8qm: add smmu node
> arm64: dts: imx8qm: add smmu stream id information
>
> .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++
> arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++
> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++

Any preference on whether all these go via a platform tree,
or should we pick up the net patch to netdev? I guess taking
the DTB via netdev would be the usual way to handle this?

2024-02-02 22:32:36

by Frank Li

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> > dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> > dt-bindings: net: fec: add iommus property
> > arm64: dts: imx8qm: add smmu node
> > arm64: dts: imx8qm: add smmu stream id information
> >
> > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++
> > Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++
> > arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++
> > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
>
> Any preference on whether all these go via a platform tree,
> or should we pick up the net patch to netdev? I guess taking
> the DTB via netdev would be the usual way to handle this?

Supposed dt-bindings go through netdev tree.

without dt-bindings, just DTB_CHECK warning. No strict dependence
relationship between dt-bindings doc and dts file.

Frank

2024-02-05 09:26:09

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On 02/02/2024 23:28, Frank Li wrote:
> On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
>> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
>>> dt-bindings: mmc: fsl-imx-esdhc: add iommus property
>>> dt-bindings: net: fec: add iommus property
>>> arm64: dts: imx8qm: add smmu node
>>> arm64: dts: imx8qm: add smmu stream id information
>>>
>>> .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++
>>> Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++
>>> arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++
>>> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
>>
>> Any preference on whether all these go via a platform tree,
>> or should we pick up the net patch to netdev? I guess taking
>> the DTB via netdev would be the usual way to handle this?
>
> Supposed dt-bindings go through netdev tree.
>
> without dt-bindings, just DTB_CHECK warning. No strict dependence
> relationship between dt-bindings doc and dts file.

Please make it easier for maintainers and sent entirely independent
patches for different subsystems in SEPARATE patchsets.

There is no dependency here between anything. Combining it, OTOH, brings
the questions about such dependency and makes it a bit more difficult to
apply for each maintainer.

Best regards,
Krzysztof


2024-02-05 21:59:45

by Frank Li

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Mon, Feb 05, 2024 at 10:25:46AM +0100, Krzysztof Kozlowski wrote:
> On 02/02/2024 23:28, Frank Li wrote:
> > On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
> >> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> >>> dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> >>> dt-bindings: net: fec: add iommus property
> >>> arm64: dts: imx8qm: add smmu node
> >>> arm64: dts: imx8qm: add smmu stream id information
> >>>
> >>> .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++
> >>> Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++
> >>> arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++
> >>> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
> >>
> >> Any preference on whether all these go via a platform tree,
> >> or should we pick up the net patch to netdev? I guess taking
> >> the DTB via netdev would be the usual way to handle this?
> >
> > Supposed dt-bindings go through netdev tree.
> >
> > without dt-bindings, just DTB_CHECK warning. No strict dependence
> > relationship between dt-bindings doc and dts file.
>
> Please make it easier for maintainers and sent entirely independent
> patches for different subsystems in SEPARATE patchsets.
>
> There is no dependency here between anything. Combining it, OTOH, brings
> the questions about such dependency and makes it a bit more difficult to
> apply for each maintainer.

Understand, but without dts change, it is not easy to understand why need
change dt-binding files.

Frank

>
> Best regards,
> Krzysztof
>

2024-02-06 10:52:46

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> > dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> > dt-bindings: net: fec: add iommus property
> > arm64: dts: imx8qm: add smmu node
> > arm64: dts: imx8qm: add smmu stream id information
> >
> > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++
> > Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++
> > arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++
> > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
>
> Any preference on whether all these go via a platform tree,
> or should we pick up the net patch to netdev? I guess taking
> the DTB via netdev would be the usual way to handle this?

No, it's not. Taking DTS changes through arch/platform tree is the
usual way.

Shawn


2024-02-06 15:42:08

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Tue, 6 Feb 2024 18:50:51 +0800 Shawn Guo wrote:
> > Any preference on whether all these go via a platform tree,
> > or should we pick up the net patch to netdev? I guess taking
> > the DTB via netdev would be the usual way to handle this?
>
> No, it's not. Taking DTS changes through arch/platform tree is the
> usual way.

I said DTB.

2024-02-19 19:53:52

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 01 Feb 2024 15:22:40 -0500 you wrote:
> Change at v2
> - Remove iM95 for fec.
>
> To: Ulf Hansson <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> To: Conor Dooley <[email protected]>
> To: Shawn Guo <[email protected]>
> To: Sascha Hauer <[email protected]>
> To: Pengutronix Kernel Team <[email protected]>
> To: Fabio Estevam <[email protected]>
> To: NXP Linux Team <[email protected]>
> To: Wei Fang <[email protected]>
> To: Shenwei Wang <[email protected]>
> To: Clark Wang <[email protected]>
> To: David S. Miller <[email protected]>
> To: Eric Dumazet <[email protected]>
> To: Jakub Kicinski <[email protected]>
> To: Paolo Abeni <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
>
> [...]

Here is the summary with links:
- [v2,1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property
(no matching commit)
- [v2,2/4] dt-bindings: net: fec: add iommus property
https://git.kernel.org/netdev/net-next/c/5983e5df8630
- [v2,3/4] arm64: dts: imx8qm: add smmu node
(no matching commit)
- [v2,4/4] arm64: dts: imx8qm: add smmu stream id information
(no matching commit)

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



2024-02-23 02:09:12

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Tue, Feb 06, 2024 at 07:41:51AM -0800, Jakub Kicinski wrote:
> On Tue, 6 Feb 2024 18:50:51 +0800 Shawn Guo wrote:
> > > Any preference on whether all these go via a platform tree,
> > > or should we pick up the net patch to netdev? I guess taking
> > > the DTB via netdev would be the usual way to handle this?
> >
> > No, it's not. Taking DTS changes through arch/platform tree is the
> > usual way.
>
> I said DTB.

If the DTB here means Device Tree Blob which is generated by DTC (Device
Tree Compiler) taking DTS (Device Tree Source) as input, it's a build
result and so neither of us could take.

Shawn


2024-02-23 02:27:03

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] Add 8qm SMMU information

On Fri, 23 Feb 2024 10:07:39 +0800 Shawn Guo wrote:
> On Tue, Feb 06, 2024 at 07:41:51AM -0800, Jakub Kicinski wrote:
> > I said DTB.
>
> If the DTB here means Device Tree Blob which is generated by DTC (Device
> Tree Compiler) taking DTS (Device Tree Source) as input, it's a build
> result and so neither of us could take.

I see, thanks for the explainer, I was referring to DeviceTree/Bindings.
I'll say binding next time.