2024-02-13 14:43:09

by Ricardo B. Marliere

Subject: [PATCH] i3c: Make i3c_bus_type const

Since commit d492cc2573a0 ("driver core: device.h: make struct
bus_type a const *"), the driver core can properly handle constant
struct bus_type, move the i3c_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/i3c/internals.h | 2 +-
drivers/i3c/master.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h
index 908a807badaf..4d99a3524171 100644
--- a/drivers/i3c/internals.h
+++ b/drivers/i3c/internals.h
@@ -10,7 +10,7 @@

#include <linux/i3c/master.h>

-extern struct bus_type i3c_bus_type;
+extern const struct bus_type i3c_bus_type;

void i3c_bus_normaluse_lock(struct i3c_bus *bus);
void i3c_bus_normaluse_unlock(struct i3c_bus *bus);
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 3afa530c5e32..f32c591ae325 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -335,7 +335,7 @@ static void i3c_device_remove(struct device *dev)
i3c_device_free_ibi(i3cdev);
}

-struct bus_type i3c_bus_type = {
+const struct bus_type i3c_bus_type = {
.name = "i3c",
.match = i3c_device_match,
.probe = i3c_device_probe,

---
base-commit: 4fa0888f6f3e6a67cac5afafb23e33f8222cfdd0
change-id: 20240213-bus_cleanup-i3c-f15a6a2ee30a

Best regards,
--
Ricardo B. Marliere <[email protected]>

2024-02-13 17:58:49

by Greg Kroah-Hartman

Subject: Re: [PATCH] i3c: Make i3c_bus_type const

On Tue, Feb 13, 2024 at 11:37:31AM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the i3c_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2024-02-19 20:24:46

by Alexandre Belloni

Subject: Re: [PATCH] i3c: Make i3c_bus_type const

On Tue, 13 Feb 2024 11:37:31 -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the i3c_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
>
>
> [...]

Applied, thanks!

[1/1] i3c: Make i3c_bus_type const
https://git.kernel.org/abelloni/c/8f06fb458539

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com