2024-02-26 07:41:36

by Krzysztof Kozlowski

Subject: [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:

"qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
fallback), thus it is enough for the "if:then:" clause to check for the
presence of the fallback "qcom,pm8350c-pwm".

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 6649ca2ec805..699db7995dd5 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -141,13 +141,13 @@ allOf:
maxItems: 1
nvmem-names:
maxItems: 1
+
- if:
properties:
compatible:
contains:
enum:
- qcom,pm8350c-pwm
- - qcom,pm8550-pwm
then:
properties:
nvmem:
--
2.34.1

2024-02-26 07:41:43

by Krzysztof Kozlowski

Subject: [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants

Only few variants support PPG and store LPG per-channel data and pattern
in SDAM modules. Disallow the nvmem for other variants to make the
binding precise.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/leds/leds-qcom-lpg.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 699db7995dd5..54a428d3d46f 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -130,6 +130,26 @@ required:
additionalProperties: false

allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,pm660l-lpg
+ - qcom,pm8150b-lpg
+ - qcom,pm8150l-lpg
+ - qcom,pm8916-pwm
+ - qcom,pm8941-lpg
+ - qcom,pm8994-lpg
+ - qcom,pmc8180c-lpg
+ - qcom,pmi8994-lpg
+ - qcom,pmi8998-lpg
+ - qcom,pmk8550-pwm
+ then:
+ properties:
+ nvmem: false
+ nvmem-names: false
+
- if:
properties:
compatible:
--
2.34.1

2024-02-27 03:48:09

by Rob Herring

Subject: Re: [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:

On Mon, 26 Feb 2024 08:37:12 +0100, Krzysztof Kozlowski wrote:
> "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
> fallback), thus it is enough for the "if:then:" clause to check for the
> presence of the fallback "qcom,pm8350c-pwm".
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2024-02-27 03:48:24

by Rob Herring

Subject: Re: [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants

On Mon, 26 Feb 2024 08:37:13 +0100, Krzysztof Kozlowski wrote:
> Only few variants support PPG and store LPG per-channel data and pattern
> in SDAM modules. Disallow the nvmem for other variants to make the
> binding precise.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/leds/leds-qcom-lpg.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2024-02-29 17:52:00

by Lee Jones

Subject: Re: [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:

On Mon, 26 Feb 2024 08:37:12 +0100, Krzysztof Kozlowski wrote:
> "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
> fallback), thus it is enough for the "if:then:" clause to check for the
> presence of the fallback "qcom,pm8350c-pwm".
>
>

Applied, thanks!

[1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:
commit: 3cc566d0a66dfcf929fb01154ac66e798106261f
[2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants
commit: 8bebf994a972369e327b1d3e8fb1a43b25d0bd09

--
Lee Jones [李琼斯]