2024-03-07 09:44:28

by Michal Simek

[permalink] [raw]
Subject: [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs

Add support for Versal and Versal NET SoCs. Both of them should use the
same IP core but differences can be in integration part that's why create
separate compatible strings.

Also describe optional power-domains property. It is optional because power
domain doesn't need to be onwed by non secure firmware hence no access to
control it via any driver.

Signed-off-by: Michal Simek <[email protected]>
---

Changes in v3:
- make versal/versal-net fallback to zynqmp

Changes in v2:
- Change subject
- Add compatible string for versal and versal NET
- Update commit message to reflect why power domain is optional.

.../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
index d1f5eb996dba..01cc90fee81e 100644
--- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
@@ -18,7 +18,13 @@ allOf:

properties:
compatible:
- const: xlnx,zynqmp-rtc
+ oneOf:
+ - const: xlnx,zynqmp-rtc
+ - items:
+ - enum:
+ - xlnx,versal-rtc
+ - xlnx,versal-net-rtc
+ - const: xlnx,zynqmp-rtc

reg:
maxItems: 1
@@ -48,6 +54,9 @@ properties:
default: 0x198233
deprecated: true

+ power-domains:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.36.1



2024-03-07 15:02:21

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs


On Thu, 07 Mar 2024 10:43:46 +0100, Michal Simek wrote:
> Add support for Versal and Versal NET SoCs. Both of them should use the
> same IP core but differences can be in integration part that's why create
> separate compatible strings.
>
> Also describe optional power-domains property. It is optional because power
> domain doesn't need to be onwed by non secure firmware hence no access to
> control it via any driver.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> Changes in v3:
> - make versal/versal-net fallback to zynqmp
>
> Changes in v2:
> - Change subject
> - Add compatible string for versal and versal NET
> - Update commit message to reflect why power domain is optional.
>
> .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>

Reviewed-by: Rob Herring <[email protected]>


2024-03-08 11:07:04

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH v3] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs

On Thu, 07 Mar 2024 10:43:46 +0100, Michal Simek wrote:
> Add support for Versal and Versal NET SoCs. Both of them should use the
> same IP core but differences can be in integration part that's why create
> separate compatible strings.
>
> Also describe optional power-domains property. It is optional because power
> domain doesn't need to be onwed by non secure firmware hence no access to
> control it via any driver.
>
> [...]

Applied, thanks!

[1/1] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs
https://git.kernel.org/abelloni/c/f0109900462d

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com