2021-02-26 06:10:20

by wangjingyu

Subject: [PATCH] radeon: ERROR: space prohibited before that ','

drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1);

Signed-off-by: wangjingyu <[email protected]>
---
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 3a6fedad002d..439d1b3e87d8 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1396,7 +1396,7 @@ static int radeon_modeset_create_props(struct radeon_device *rdev)

if (rdev->is_atom_bios) {
rdev->mode_info.coherent_mode_property =
- drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1);
+ drm_property_create_range(rdev->ddev, 0, "coherent", 0, 1);
if (!rdev->mode_info.coherent_mode_property)
return -ENOMEM;
}
--
2.11.0

2021-02-26 07:52:43

by Christian König

Subject: Re: [PATCH] radeon: ERROR: space prohibited before that ','

Well coding style clean ups are usually welcome, but not necessarily one
by one.

We can probably merge this if you clean up all checkpatch.pl warnings in
the whole file.

Christian.

Am 26.02.21 um 07:05 schrieb wangjingyu:
> drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1);
>
> Signed-off-by: wangjingyu <[email protected]>
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 3a6fedad002d..439d1b3e87d8 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1396,7 +1396,7 @@ static int radeon_modeset_create_props(struct radeon_device *rdev)
>
> if (rdev->is_atom_bios) {
> rdev->mode_info.coherent_mode_property =
> - drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1);
> + drm_property_create_range(rdev->ddev, 0, "coherent", 0, 1);
> if (!rdev->mode_info.coherent_mode_property)
> return -ENOMEM;
> }