2024-02-11 22:16:38

by Randy Dunlap

Subject: [PATCH] powerpc/32: fix ADB_CUDA kconfig warning

From: Michael Ellerman <[email protected]>

Fix a (randconfig) kconfig warning by correcting the select
statement:

WARNING: unmet direct dependencies detected for ADB_CUDA
Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
Selected by [y]:
- PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]

The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32).

Fixes: a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32")
Signed-off-by: Michael Ellerman <[email protected]>
Signed-off-by: Randy Dunlap <[email protected]>
Tested: Randy Dunlap <[email protected]>
Cc: Yuan Tan <[email protected]>
---
arch/powerpc/platforms/powermac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
--- a/arch/powerpc/platforms/powermac/Kconfig
+++ b/arch/powerpc/platforms/powermac/Kconfig
@@ -2,7 +2,7 @@
config PPC_PMAC
bool "Apple PowerMac based machines"
depends on PPC_BOOK3S && CPU_BIG_ENDIAN
- select ADB_CUDA if POWER_RESET && PPC32
+ select ADB_CUDA if POWER_RESET && ADB
select MPIC
select FORCE_PCI
select PPC_INDIRECT_PCI if PPC32

2024-03-13 13:29:50

by Michael Ellerman

Subject: Re: [PATCH] powerpc/32: fix ADB_CUDA kconfig warning

On Sun, 11 Feb 2024 14:16:23 -0800, Randy Dunlap wrote:
> Fix a (randconfig) kconfig warning by correcting the select
> statement:
>
> WARNING: unmet direct dependencies detected for ADB_CUDA
> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
> Selected by [y]:
> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>
> [...]

Applied to powerpc/next.

[1/1] powerpc/32: fix ADB_CUDA kconfig warning
https://git.kernel.org/powerpc/c/b72c066ba85a131091498a15a62d6068997278a4

cheers