2024-03-14 02:58:24

by Jiapeng Chong

Subject: [PATCH] block: Modify mismatched function name

No functional modification involved.

block/blk-settings.c:281: warning: expecting prototype for queue_limits_commit_set(). Prototype was for queue_limits_set() instead.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8539
Signed-off-by: Jiapeng Chong <[email protected]>
---
block/blk-settings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index e160d56e8eda..3c7d8d638ab5 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -267,7 +267,7 @@ int queue_limits_commit_update(struct request_queue *q,
EXPORT_SYMBOL_GPL(queue_limits_commit_update);

/**
- * queue_limits_commit_set - apply queue limits to queue
+ * queue_limits_set - apply queue limits to queue
* @q: queue to update
* @lim: limits to apply
*
--
2.20.1.7.g153144c

2024-03-14 05:07:45

by Randy Dunlap

Subject: Re: [PATCH] block: Modify mismatched function name

On 3/13/24 19:56, Jiapeng Chong wrote:
> No functional modification involved.
>
> block/blk-settings.c:281: warning: expecting prototype for queue_limits_commit_set(). Prototype was for queue_limits_set() instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8539
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> block/blk-settings.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-settings.c b/block/blk-settings.c
> index e160d56e8eda..3c7d8d638ab5 100644
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@ -267,7 +267,7 @@ int queue_limits_commit_update(struct request_queue *q,
> EXPORT_SYMBOL_GPL(queue_limits_commit_update);
>
> /**
> - * queue_limits_commit_set - apply queue limits to queue
> + * queue_limits_set - apply queue limits to queue
> * @q: queue to update
> * @lim: limits to apply
> *

--
#Randy

2024-03-14 15:41:08

by Jens Axboe

Subject: Re: [PATCH] block: Modify mismatched function name

On Thu, 14 Mar 2024 10:56:15 +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> block/blk-settings.c:281: warning: expecting prototype for queue_limits_commit_set(). Prototype was for queue_limits_set() instead.
>
>

Applied, thanks!

[1/1] block: Modify mismatched function name
commit: 4c4ab8ae416350ce817339f239bdaaf351212f15

Best regards,
--
Jens Axboe