2024-03-28 20:00:29

by Dmitry Rokosov

Subject: [PATCH v1] clk: meson: pll: print out pll name when unable to lock it

In most meson systems, multiple PLLs are present, making it difficult to
identify the specific PLL that fails to lock. To address this issue,
print out the name of the PLL that cannot be locked.

Signed-off-by: Dmitry Rokosov <[email protected]>
---
drivers/clk/meson/clk-pll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 6fa7639a3050..78d17b2415af 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -436,8 +436,8 @@ static int meson_clk_pll_set_rate(struct clk_hw *hw, unsigned long rate,

ret = meson_clk_pll_enable(hw);
if (ret) {
- pr_warn("%s: pll did not lock, trying to restore old rate %lu\n",
- __func__, old_rate);
+ pr_warn("%s: pll %s didn't lock, trying to set old rate %lu\n",
+ __func__, clk_hw_get_name(hw), old_rate);
/*
* FIXME: Do we really need/want this HACK ?
* It looks unsafe. what happens if the clock gets into a
--
2.43.0

2024-03-29 11:27:27

by Jerome Brunet

Subject: Re: [PATCH v1] clk: meson: pll: print out pll name when unable to lock it

Applied to clk-meson (v6.10/drivers), thanks!

[1/1] clk: meson: pll: print out pll name when unable to lock it
https://github.com/BayLibre/clk-meson/commit/16182ac30a68

Best regards,
--
Jerome