2024-02-29 19:49:53

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 0/4] arm64: dts: mediatek: Add missing gce-client-reg properties to mt8192 and mt8195

This series adds the gce-client-reg properties to the nodes where it was
missing in order to avoid "error -2 can't parse gce-client-reg property"
errors and possibly improve the performance. The separation of the
commits was done in order for each one to have a single Fixes tag and
therefore be more easily backported.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
Nícolas F. R. A. Prado (4):
arm64: dts: mediatek: mt8192: Add missing gce-client-reg to mutex
arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdosys
arm64: dts: mediatek: mt8195: Add missing gce-client-reg to mutex
arm64: dts: mediatek: mt8195: Add missing gce-client-reg to mutex1

arch/arm64/boot/dts/mediatek/mt8192.dtsi | 1 +
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 5 +++++
2 files changed, 6 insertions(+)
---
base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29
change-id: 20240229-gce-client-reg-add-missing-mt8192-95-d05c0659c8ca

Best regards,
--
Nícolas F. R. A. Prado <[email protected]>



2024-02-29 19:51:43

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 3/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to mutex

Add the missing mediatek,gce-client-reg property to the mutex node to
allow it to use the GCE. This prevents the "can't parse gce-client-reg
property" error from being printed and should result in better
performance.

Fixes: b852ee68fd72 ("arm64: dts: mt8195: Add display node for vdosys0")
Suggested-by: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index f2912e1a0e49..fd074103979c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -3264,6 +3264,7 @@ mutex: mutex@1c016000 {
interrupts = <GIC_SPI 658 IRQ_TYPE_LEVEL_HIGH 0>;
power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
clocks = <&vdosys0 CLK_VDO0_DISP_MUTEX0>;
+ mediatek,gce-client-reg = <&gce0 SUBSYS_1c01XXXX 0x6000 0x1000>;
mediatek,gce-events = <CMDQ_EVENT_VDO0_DISP_STREAM_DONE_0>;
};


--
2.44.0


2024-02-29 19:52:10

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 4/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to mutex1

Add the missing mediatek,gce-client-reg property to the mutex1 node to
allow it to use the GCE. This prevents the "can't parse gce-client-reg
property" error from being printed and should result in better
performance.

Fixes: 92d2c23dc269 ("arm64: dts: mt8195: add display node for vdosys1")
Suggested-by: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index fd074103979c..5d8b68f86ce4 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -3335,6 +3335,7 @@ mutex1: mutex@1c101000 {
power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS1>;
clocks = <&vdosys1 CLK_VDO1_DISP_MUTEX>;
clock-names = "vdo1_mutex";
+ mediatek,gce-client-reg = <&gce0 SUBSYS_1c10XXXX 0x1000 0x1000>;
mediatek,gce-events = <CMDQ_EVENT_VDO1_STREAM_DONE_ENG_0>;
};


--
2.44.0


Subject: Re: [PATCH 0/4] arm64: dts: mediatek: Add missing gce-client-reg properties to mt8192 and mt8195

On Thu, 29 Feb 2024 14:44:27 -0500, Nícolas F. R. A. Prado wrote:
> This series adds the gce-client-reg properties to the nodes where it was
> missing in order to avoid "error -2 can't parse gce-client-reg property"
> errors and possibly improve the performance. The separation of the
> commits was done in order for each one to have a single Fixes tag and
> therefore be more easily backported.
>
>
> [...]

Applied to v6.9-fixes/dts64, thanks!

[1/4] arm64: dts: mediatek: mt8192: Add missing gce-client-reg to mutex
commit: 00bcc8810d9dd69d3899a4189e2f3964f263a600
[2/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdosys
commit: 96b0c1528ef41fe754f5d1378b1db6c098a2e33f
[3/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to mutex
commit: 3b129949184a1251e6a42db714f6d68b75fabedd
[4/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to mutex1
commit: 58f126296c3c52d02bf3fad1f68c331d718c4a9b

Cheers,
Angelo