2024-03-30 11:13:36

by Stafford Horne

[permalink] [raw]
Subject: [PATCH v2] riscv: Remove unused asm/signal.h file

When riscv moved to common entry the definition and usage of
do_work_pending was removed. This unused header file remains.

Remove the header file as it is not used.

I have tested compiling the kernel with this patch applied and saw no
issues. Noticed when auditing how different ports handle signals
related to saving FPU state.

Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
Signed-off-by: Stafford Horne <[email protected]>
Reviewed-by: Guo Ren <[email protected]>
---
Resending with reviewed-by.

arch/riscv/include/asm/signal.h | 12 ------------
1 file changed, 12 deletions(-)
delete mode 100644 arch/riscv/include/asm/signal.h

diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
deleted file mode 100644
index 956ae0a01bad..000000000000
--- a/arch/riscv/include/asm/signal.h
+++ /dev/null
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef __ASM_SIGNAL_H
-#define __ASM_SIGNAL_H
-
-#include <uapi/asm/signal.h>
-#include <uapi/asm/ptrace.h>
-
-asmlinkage __visible
-void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
-
-#endif
--
2.44.0



Subject: Re: [PATCH v2] riscv: Remove unused asm/signal.h file

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <[email protected]>:

On Sat, 30 Mar 2024 11:13:05 +0000 you wrote:
> When riscv moved to common entry the definition and usage of
> do_work_pending was removed. This unused header file remains.
>
> Remove the header file as it is not used.
>
> I have tested compiling the kernel with this patch applied and saw no
> issues. Noticed when auditing how different ports handle signals
> related to saving FPU state.
>
> [...]

Here is the summary with links:
- [v2] riscv: Remove unused asm/signal.h file
https://git.kernel.org/riscv/c/3dfbd2d26b64

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html