2024-04-11 06:05:43

by Ruyi Zhang

[permalink] [raw]
Subject: [PATCH] io_uring/timeout: remove duplicate initialization of the io_timeout list.

In the __io_timeout_prep function, the io_timeout list is initialized
twice, removing the meaningless second initialization.

Signed-off-by: Ruyi Zhang <[email protected]>
---
io_uring/timeout.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/io_uring/timeout.c b/io_uring/timeout.c
index 7fd7dbb211d6..93ff94e82fd4 100644
--- a/io_uring/timeout.c
+++ b/io_uring/timeout.c
@@ -541,7 +541,6 @@ static int __io_timeout_prep(struct io_kiocb *req,
if (data->ts.tv_sec < 0 || data->ts.tv_nsec < 0)
return -EINVAL;

- INIT_LIST_HEAD(&timeout->list);
data->mode = io_translate_timeout_mode(flags);
hrtimer_init(&data->timer, io_timeout_get_clock(data), data->mode);

--
2.40.1



2024-04-11 13:35:09

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] io_uring/timeout: remove duplicate initialization of the io_timeout list.


On Thu, 11 Apr 2024 13:59:53 +0800, Ruyi Zhang wrote:
> In the __io_timeout_prep function, the io_timeout list is initialized
> twice, removing the meaningless second initialization.
>
>

Applied, thanks!

[1/1] io_uring/timeout: remove duplicate initialization of the io_timeout list.
commit: 99e440c5b1d70084eeb2097bd035e50c2de62884

Best regards,
--
Jens Axboe