2024-04-10 14:51:31

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next] tls: remove redundant assignment to variable decrypted

The variable decrypted is being assigned a value that is never read,
the control of flow after the assignment is via an return path and
decrypted is not referenced in this path. The assignment is redundant
and can be removed.

Cleans up clang scan warning:
net/tls/tls_sw.c:2150:4: warning: Value stored to 'decrypted' is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
net/tls/tls_sw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index b783231668c6..305a412785f5 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -2147,7 +2147,6 @@ int tls_sw_recvmsg(struct sock *sk,
if (ret) {
if (err >= 0 || err == -EINPROGRESS)
err = ret;
- decrypted = 0;
goto end;
}

--
2.39.2



2024-04-12 03:10:50

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH][next] tls: remove redundant assignment to variable decrypted

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 10 Apr 2024 15:41:36 +0100 you wrote:
> The variable decrypted is being assigned a value that is never read,
> the control of flow after the assignment is via an return path and
> decrypted is not referenced in this path. The assignment is redundant
> and can be removed.
>
> Cleans up clang scan warning:
> net/tls/tls_sw.c:2150:4: warning: Value stored to 'decrypted' is never
> read [deadcode.DeadStores]
>
> [...]

Here is the summary with links:
- [next] tls: remove redundant assignment to variable decrypted
https://git.kernel.org/netdev/net-next/c/f7ac8fbd3215

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html