2024-04-13 06:52:31

by Anup Patel

Subject: [PATCH] irqchip/riscv-imsic: Fix boot time update effective affinity warning

Currently, the following warning is observed on the QEMU virt machine:
genirq: irq_chip APLIC-MSI-d000000.aplic did not update eff. affinity mask of irq 12

The above warning is because the IMSIC driver does not set the initial
value of effective affinity in the irq descriptor. To address this,
initialize the effective affinity in imsic_irq_domain_alloc().

Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Anup Patel <[email protected]>
---
drivers/irqchip/irq-riscv-imsic-platform.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 1e6dddfd3046..11723a763c10 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -157,6 +157,7 @@ static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
handle_simple_irq, NULL, NULL);
irq_set_noprobe(virq);
irq_set_affinity(virq, cpu_online_mask);
+ irq_data_update_effective_affinity(irq_get_irq_data(virq), cpumask_of(vec->cpu));

return 0;
}
--
2.34.1

2024-04-14 11:37:37

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/core] irqchip/riscv-imsic: Fix boot time update effective affinity warning

The following commit has been merged into the irq/core branch of tip:

Commit-ID: 35d77eb7b974f62aaef5a0dc72d93ddb1ada4074
Gitweb: https://git.kernel.org/tip/35d77eb7b974f62aaef5a0dc72d93ddb1ada4074
Author: Anup Patel <[email protected]>
AuthorDate: Sat, 13 Apr 2024 12:22:10 +05:30
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Sun, 14 Apr 2024 13:28:49 +02:00

irqchip/riscv-imsic: Fix boot time update effective affinity warning

Currently, the following warning is observed on the QEMU virt machine:
genirq: irq_chip APLIC-MSI-d000000.aplic did not update eff. affinity mask of irq 12

The above warning is because the IMSIC driver does not set the initial
value of effective affinity in the interrupt descriptor. To address this,
initialize the effective affinity in imsic_irq_domain_alloc().

Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Anup Patel <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
drivers/irqchip/irq-riscv-imsic-platform.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 1e6dddf..11723a7 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -157,6 +157,7 @@ static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
handle_simple_irq, NULL, NULL);
irq_set_noprobe(virq);
irq_set_affinity(virq, cpu_online_mask);
+ irq_data_update_effective_affinity(irq_get_irq_data(virq), cpumask_of(vec->cpu));

return 0;
}