2024-04-14 16:47:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] ASoC: amd: acp-da7219-max98357a: Constify regulator_ops

Neither core nor the driver modifes 'struct regulator_ops', so it can be
const for code safety.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
sound/soc/amd/acp-da7219-max98357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 84f3d65ba52e..77cf72082e73 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -733,7 +733,7 @@ static struct regulator_config acp_da7219_cfg = {
.init_data = &acp_da7219_data,
};

-static struct regulator_ops acp_da7219_ops = {
+static const struct regulator_ops acp_da7219_ops = {
};

static const struct regulator_desc acp_da7219_desc = {
--
2.34.1



2024-04-15 11:13:29

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: amd: acp-da7219-max98357a: Constify regulator_ops

On Sun, 14 Apr 2024 18:47:03 +0200, Krzysztof Kozlowski wrote:
> Neither core nor the driver modifes 'struct regulator_ops', so it can be
> const for code safety.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: acp-da7219-max98357a: Constify regulator_ops
commit: dd8c3473bbb8b4fdc44ed3a5a864cfefab9038dd

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark