2024-04-14 15:49:29

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] rtc: mcp795: drop unneeded MODULE_ALIAS

The ID table already has respective entry and MODULE_DEVICE_TABLE and
creates proper alias for SPI driver. Having another MODULE_ALIAS causes
the alias to be duplicated.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/rtc/rtc-mcp795.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c
index 0d515b3df571..e12f0f806ec4 100644
--- a/drivers/rtc/rtc-mcp795.c
+++ b/drivers/rtc/rtc-mcp795.c
@@ -450,4 +450,3 @@ module_spi_driver(mcp795_driver);
MODULE_DESCRIPTION("MCP795 RTC SPI Driver");
MODULE_AUTHOR("Josef Gajdusek <[email protected]>");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("spi:mcp795");
--
2.34.1



2024-04-16 23:44:04

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH] rtc: mcp795: drop unneeded MODULE_ALIAS

On Sun, 14 Apr 2024 17:49:10 +0200, Krzysztof Kozlowski wrote:
> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
> the alias to be duplicated.
>
>

Applied, thanks!

[1/1] rtc: mcp795: drop unneeded MODULE_ALIAS
https://git.kernel.org/abelloni/c/393e3d290f61

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com