2024-01-09 19:24:26

by Besar Wicaksono

[permalink] [raw]
Subject: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE

This series support Neoverse-V2 CPU in Perf Arm SPE.
The first patch adds the Neoverse-V2 part number in kernel header.
The second patch syncs the kernel change to the tools header.
The third patch adds Neoverse-V2 into perf's Neoverse SPE data source list.

Besar Wicaksono (3):
arm64: Add Neoverse-V2 part
tools headers arm64: Add Neoverse-V2 part
perf arm-spe: Add Neoverse-V2 to neoverse list

arch/arm64/include/asm/cputype.h | 2 ++
tools/arch/arm64/include/asm/cputype.h | 2 ++
tools/perf/util/arm-spe.c | 1 +
3 files changed, 5 insertions(+)


base-commit: d988c9f511af71a3445b6a4f3a2c67208ff8e480
--
2.17.1



2024-01-09 19:24:44

by Besar Wicaksono

[permalink] [raw]
Subject: [PATCH v1 1/3] arm64: Add Neoverse-V2 part

Add the part number and MIDR for Neoverse-V2

Signed-off-by: Besar Wicaksono <[email protected]>
---
arch/arm64/include/asm/cputype.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
index 7c7493cb571f..fe13a25fa082 100644
--- a/arch/arm64/include/asm/cputype.h
+++ b/arch/arm64/include/asm/cputype.h
@@ -85,6 +85,7 @@
#define ARM_CPU_PART_CORTEX_X2 0xD48
#define ARM_CPU_PART_NEOVERSE_N2 0xD49
#define ARM_CPU_PART_CORTEX_A78C 0xD4B
+#define ARM_CPU_PART_NEOVERSE_V2 0xD4F

#define APM_CPU_PART_XGENE 0x000
#define APM_CPU_VAR_POTENZA 0x00
@@ -156,6 +157,7 @@
#define MIDR_CORTEX_X2 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_X2)
#define MIDR_NEOVERSE_N2 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N2)
#define MIDR_CORTEX_A78C MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A78C)
+#define MIDR_NEOVERSE_V2 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_V2)
#define MIDR_THUNDERX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX)
#define MIDR_THUNDERX_81XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_81XX)
#define MIDR_THUNDERX_83XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_83XX)
--
2.17.1


2024-01-09 19:25:50

by Besar Wicaksono

[permalink] [raw]
Subject: [PATCH v1 2/3] tools headers arm64: Add Neoverse-V2 part

Add the part number and MIDR for Neoverse-V2.

Signed-off-by: Besar Wicaksono <[email protected]>
---
tools/arch/arm64/include/asm/cputype.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/arch/arm64/include/asm/cputype.h b/tools/arch/arm64/include/asm/cputype.h
index 7c7493cb571f..fe13a25fa082 100644
--- a/tools/arch/arm64/include/asm/cputype.h
+++ b/tools/arch/arm64/include/asm/cputype.h
@@ -85,6 +85,7 @@
#define ARM_CPU_PART_CORTEX_X2 0xD48
#define ARM_CPU_PART_NEOVERSE_N2 0xD49
#define ARM_CPU_PART_CORTEX_A78C 0xD4B
+#define ARM_CPU_PART_NEOVERSE_V2 0xD4F

#define APM_CPU_PART_XGENE 0x000
#define APM_CPU_VAR_POTENZA 0x00
@@ -156,6 +157,7 @@
#define MIDR_CORTEX_X2 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_X2)
#define MIDR_NEOVERSE_N2 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N2)
#define MIDR_CORTEX_A78C MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A78C)
+#define MIDR_NEOVERSE_V2 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_V2)
#define MIDR_THUNDERX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX)
#define MIDR_THUNDERX_81XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_81XX)
#define MIDR_THUNDERX_83XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_83XX)
--
2.17.1


2024-01-09 19:26:32

by Besar Wicaksono

[permalink] [raw]
Subject: [PATCH v1 3/3] perf arm-spe: Add Neoverse-V2 to neoverse list

Add Neoverse-V2 MIDR to neoverse_spe range list.

Signed-off-by: Besar Wicaksono <[email protected]>
---
tools/perf/util/arm-spe.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index afbd5869f6bf..936d2222e6d7 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -413,6 +413,7 @@ static const struct midr_range neoverse_spe[] = {
MIDR_ALL_VERSIONS(MIDR_NEOVERSE_N1),
MIDR_ALL_VERSIONS(MIDR_NEOVERSE_N2),
MIDR_ALL_VERSIONS(MIDR_NEOVERSE_V1),
+ MIDR_ALL_VERSIONS(MIDR_NEOVERSE_V2),
{},
};

--
2.17.1


2024-01-10 01:14:37

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH v1 3/3] perf arm-spe: Add Neoverse-V2 to neoverse list

On Tue, Jan 09, 2024 at 01:23:10PM -0600, Besar Wicaksono wrote:
> Add Neoverse-V2 MIDR to neoverse_spe range list.
>
> Signed-off-by: Besar Wicaksono <[email protected]>

This patch series looks good to me:

Reviewed-by: Leo Yan <[email protected]>

2024-01-10 09:12:25

by James Clark

[permalink] [raw]
Subject: Re: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE



On 09/01/2024 19:23, Besar Wicaksono wrote:
> This series support Neoverse-V2 CPU in Perf Arm SPE.
> The first patch adds the Neoverse-V2 part number in kernel header.
> The second patch syncs the kernel change to the tools header.
> The third patch adds Neoverse-V2 into perf's Neoverse SPE data source list.
>
> Besar Wicaksono (3):
> arm64: Add Neoverse-V2 part
> tools headers arm64: Add Neoverse-V2 part
> perf arm-spe: Add Neoverse-V2 to neoverse list
>
> arch/arm64/include/asm/cputype.h | 2 ++
> tools/arch/arm64/include/asm/cputype.h | 2 ++
> tools/perf/util/arm-spe.c | 1 +
> 3 files changed, 5 insertions(+)
>
>
> base-commit: d988c9f511af71a3445b6a4f3a2c67208ff8e480

Reviewed-by: James Clark <[email protected]>

2024-04-15 15:57:06

by Besar Wicaksono

[permalink] [raw]
Subject: RE: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE

Hi,

Do we need any more feedback to this series?

Thanks,
Besar

> -----Original Message-----
> From: Besar Wicaksono <[email protected]>
> Sent: Tuesday, January 9, 2024 1:23 PM
> To: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Vikram Sethi
> <[email protected]>; Richard Wiley <[email protected]>; Yifei Wan
> <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Thierry Reding
> <[email protected]>; Jonathan Hunter <[email protected]>; Besar
> Wicaksono <[email protected]>
> Subject: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE
>
> This series support Neoverse-V2 CPU in Perf Arm SPE.
> The first patch adds the Neoverse-V2 part number in kernel header.
> The second patch syncs the kernel change to the tools header.
> The third patch adds Neoverse-V2 into perf's Neoverse SPE data source list.
>
> Besar Wicaksono (3):
> arm64: Add Neoverse-V2 part
> tools headers arm64: Add Neoverse-V2 part
> perf arm-spe: Add Neoverse-V2 to neoverse list
>
> arch/arm64/include/asm/cputype.h | 2 ++
> tools/arch/arm64/include/asm/cputype.h | 2 ++
> tools/perf/util/arm-spe.c | 1 +
> 3 files changed, 5 insertions(+)
>
>
> base-commit: d988c9f511af71a3445b6a4f3a2c67208ff8e480
> --
> 2.17.1


2024-04-19 15:33:33

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE

On Tue, 09 Jan 2024 13:23:07 -0600, Besar Wicaksono wrote:
> This series support Neoverse-V2 CPU in Perf Arm SPE.
> The first patch adds the Neoverse-V2 part number in kernel header.
> The second patch syncs the kernel change to the tools header.
> The third patch adds Neoverse-V2 into perf's Neoverse SPE data source list.
>
> Besar Wicaksono (3):
> arm64: Add Neoverse-V2 part
> tools headers arm64: Add Neoverse-V2 part
> perf arm-spe: Add Neoverse-V2 to neoverse list
>
> [...]

Applied arch/arm64 part to arm64 (for-next/misc), thanks!

[1/3] arm64: Add Neoverse-V2 part
https://git.kernel.org/arm64/c/f4d9d9dcc70b

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

2024-04-30 17:51:01

by Besar Wicaksono

[permalink] [raw]
Subject: RE: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE

Hi Arnaldo,

Could you take these changes for perf?
[2/3] tools headers arm64: Add Neoverse-V2 part
[3/3] perf arm-spe: Add Neoverse-V2 to neoverse list

Thanks,
Besar

> -----Original Message-----
> From: Besar Wicaksono <[email protected]>
> Sent: Monday, April 15, 2024 10:57 AM
> To: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Vikram Sethi
> <[email protected]>; Rich Wiley <[email protected]>; Yifei Wan
> <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Thierry Reding
> <[email protected]>; Jon Hunter <[email protected]>; Sean Kelley
> <[email protected]>
> Subject: RE: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE
>
> Hi,
>
> Do we need any more feedback to this series?
>
> Thanks,
> Besar
>
> > -----Original Message-----
> > From: Besar Wicaksono <[email protected]>
> > Sent: Tuesday, January 9, 2024 1:23 PM
> > To: [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected];
> [email protected];
> > [email protected]; [email protected]; Vikram Sethi
> > <[email protected]>; Richard Wiley <[email protected]>; Yifei Wan
> > <[email protected]>
> > Cc: [email protected]; [email protected]; linux-
> > [email protected]; [email protected]; Thierry Reding
> > <[email protected]>; Jonathan Hunter <[email protected]>; Besar
> > Wicaksono <[email protected]>
> > Subject: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE
> >
> > This series support Neoverse-V2 CPU in Perf Arm SPE.
> > The first patch adds the Neoverse-V2 part number in kernel header.
> > The second patch syncs the kernel change to the tools header.
> > The third patch adds Neoverse-V2 into perf's Neoverse SPE data source list.
> >
> > Besar Wicaksono (3):
> > arm64: Add Neoverse-V2 part
> > tools headers arm64: Add Neoverse-V2 part
> > perf arm-spe: Add Neoverse-V2 to neoverse list
> >
> > arch/arm64/include/asm/cputype.h | 2 ++
> > tools/arch/arm64/include/asm/cputype.h | 2 ++
> > tools/perf/util/arm-spe.c | 1 +
> > 3 files changed, 5 insertions(+)
> >
> >
> > base-commit: d988c9f511af71a3445b6a4f3a2c67208ff8e480
> > --
> > 2.17.1


2024-04-30 20:27:42

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH v1 0/3] arm64: Support Neoverse-V2 for Perf Arm SPE

On Tue, Apr 30, 2024 at 05:50:40PM +0000, Besar Wicaksono wrote:
> Hi Arnaldo,
>
> Could you take these changes for perf?
> [2/3] tools headers arm64: Add Neoverse-V2 part
> [3/3] perf arm-spe: Add Neoverse-V2 to neoverse list

Thanks for bringing up this.

I confirmed this patch series can be cleanly applied on the mainline
kernel, so the above two patches look good to me.

Thanks,
Leo