2024-04-18 18:33:40

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net v2] net: bcmasp: fix memory leak when bringing down interface

On Thu, Apr 18, 2024 at 11:05:41AM -0700, Justin Chen wrote:
> When bringing down the TX rings we flush the rings but forget to
> reclaimed the flushed packets. This leads to a memory leak since we
> do not free the dma mapped buffers. This also leads to tx control
> block corruption when bringing down the interface for power
> management.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <[email protected]>
> Acked-by: Florian Fainelli <[email protected]>

Reviewed-by: Simon Horman <[email protected]>



2024-04-20 03:40:38

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net v2] net: bcmasp: fix memory leak when bringing down interface

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 18 Apr 2024 11:05:41 -0700 you wrote:
> When bringing down the TX rings we flush the rings but forget to
> reclaimed the flushed packets. This leads to a memory leak since we
> do not free the dma mapped buffers. This also leads to tx control
> block corruption when bringing down the interface for power
> management.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <[email protected]>
> Acked-by: Florian Fainelli <[email protected]>
>
> [...]

Here is the summary with links:
- [net,v2] net: bcmasp: fix memory leak when bringing down interface
https://git.kernel.org/netdev/net/c/9f898fc2c31f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html