2024-04-10 19:16:05

by Krzysztof Kozlowski

Subject: [PATCH v2] soc: qcom: mention intentionally broken module autoloading

Qualcomm PMIC ChargerPD ULOG and RPM Master Statistics drivers are
solely for debugging purposes and should not be autoloaded as modules.
Add comments to annotate missing MODULE_DEVICE_TABLE.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes in v2:
1. Rework, drop MODULE_DEVICE_TABLE, add comment.
---
drivers/soc/qcom/pmic_pdcharger_ulog.c | 4 ++++
drivers/soc/qcom/rpm_master_stats.c | 4 ++++
2 files changed, 8 insertions(+)

diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.c b/drivers/soc/qcom/pmic_pdcharger_ulog.c
index 238cd38589dc..39f412bbf2c1 100644
--- a/drivers/soc/qcom/pmic_pdcharger_ulog.c
+++ b/drivers/soc/qcom/pmic_pdcharger_ulog.c
@@ -150,6 +150,10 @@ static const struct rpmsg_device_id pmic_pdcharger_ulog_rpmsg_id_match[] = {
{ "PMIC_LOGS_ADSP_APPS" },
{}
};
+/*
+ * No MODULE_DEVICE_TABLE intentionally: that's a debugging module, to be
+ * loaded manually only.
+ */

static struct rpmsg_driver pmic_pdcharger_ulog_rpmsg_driver = {
.probe = pmic_pdcharger_ulog_rpmsg_probe,
diff --git a/drivers/soc/qcom/rpm_master_stats.c b/drivers/soc/qcom/rpm_master_stats.c
index 9ca13bcf67d3..086fe4ba6707 100644
--- a/drivers/soc/qcom/rpm_master_stats.c
+++ b/drivers/soc/qcom/rpm_master_stats.c
@@ -148,6 +148,10 @@ static const struct of_device_id rpm_master_table[] = {
{ .compatible = "qcom,rpm-master-stats" },
{ },
};
+/*
+ * No MODULE_DEVICE_TABLE intentionally: that's a debugging module, to be
+ * loaded manually only.
+ */

static struct platform_driver master_stats_driver = {
.probe = master_stats_probe,
--
2.34.1

2024-04-21 22:31:02

by Bjorn Andersson

Subject: Re: [PATCH v2] soc: qcom: mention intentionally broken module autoloading

On Wed, 10 Apr 2024 20:45:22 +0200, Krzysztof Kozlowski wrote:
> Qualcomm PMIC ChargerPD ULOG and RPM Master Statistics drivers are
> solely for debugging purposes and should not be autoloaded as modules.
> Add comments to annotate missing MODULE_DEVICE_TABLE.
>
>

Applied, thanks!

[1/1] soc: qcom: mention intentionally broken module autoloading
commit: 77706838f837785189578bd8fd768e646e63f8c2

Best regards,
--
Bjorn Andersson <[email protected]>