2024-03-11 19:17:44

by Gabor Juhos

[permalink] [raw]
Subject: [PATCH 0/2] clk: qcom: clk-alpha-pll: Stromer register cleanup

This small set contains two patches which are intended to clean
up the Stromer specific register offsets in 'clk_alpha_pll_regs'
a bit.

Based on v6.8.

Signed-off-by: Gabor Juhos <[email protected]>
---
Gabor Juhos (2):
clk: qcom: clk-alpha-pll: remove invalid Stromer register offset
clk: qcom: clk-alpha-pll: reorder Stromer register offsets

drivers/clk/qcom/clk-alpha-pll.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
---
base-commit: e8f897f4afef0031fe618a8e94127a0934896aba
change-id: 20240311-alpha-pll-stromer-cleanup-01b577e75264

Best regards,
--
Gabor Juhos <[email protected]>



2024-03-11 19:17:54

by Gabor Juhos

[permalink] [raw]
Subject: [PATCH 2/2] clk: qcom: clk-alpha-pll: reorder Stromer register offsets

The register offset arrays are ordered based on the register
offsets for all PLLs but the Stromer. For consistency, reorder
the Stromer specific array as well.

No functional changes.

Signed-off-by: Gabor Juhos <[email protected]>
---
drivers/clk/qcom/clk-alpha-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
index 58ae732959803..55a77e36dc44c 100644
--- a/drivers/clk/qcom/clk-alpha-pll.c
+++ b/drivers/clk/qcom/clk-alpha-pll.c
@@ -212,9 +212,9 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = {
[PLL_OFF_USER_CTL] = 0x18,
[PLL_OFF_USER_CTL_U] = 0x1c,
[PLL_OFF_CONFIG_CTL] = 0x20,
+ [PLL_OFF_STATUS] = 0x28,
[PLL_OFF_TEST_CTL] = 0x30,
[PLL_OFF_TEST_CTL_U] = 0x34,
- [PLL_OFF_STATUS] = 0x28,
},
[CLK_ALPHA_PLL_TYPE_STROMER_PLUS] = {
[PLL_OFF_L_VAL] = 0x04,

--
2.44.0


2024-03-12 00:02:30

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/2] clk: qcom: clk-alpha-pll: reorder Stromer register offsets



On 3/11/24 19:45, Gabor Juhos wrote:
> The register offset arrays are ordered based on the register
> offsets for all PLLs but the Stromer. For consistency, reorder
> the Stromer specific array as well.
>
> No functional changes.
>
> Signed-off-by: Gabor Juhos <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2024-04-21 22:30:14

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/2] clk: qcom: clk-alpha-pll: Stromer register cleanup


On Mon, 11 Mar 2024 19:45:18 +0100, Gabor Juhos wrote:
> This small set contains two patches which are intended to clean
> up the Stromer specific register offsets in 'clk_alpha_pll_regs'
> a bit.
>
> Based on v6.8.
>
>
> [...]

Applied, thanks!

[1/2] clk: qcom: clk-alpha-pll: remove invalid Stromer register offset
commit: 4f2bc4acbb1916b8cd2ce4bb3ba7b1cd7cb705fa
[2/2] clk: qcom: clk-alpha-pll: reorder Stromer register offsets
commit: 8c48466cd7eda9afb37f26c8c9a68f39fae5ef32

Best regards,
--
Bjorn Andersson <[email protected]>