From: Zoie Lin <[email protected]>
Based on tag: next-20240426, linux-next/master
v1:
Add support for the dovdd regulator, which supplies an
additional power source to the EEPROM.
Zoie Lin (3):
misc: eeprom: at24: add optional dovdd-supply
dt-bindings: eeprom: at24: Add support for at24c64
dt-bindings: eeprom: at24: Add property dovdd-supply
.../devicetree/bindings/eeprom/at24.yaml | 6 +++
drivers/misc/eeprom/at24.c | 37 ++++++++++++++++++-
2 files changed, 41 insertions(+), 2 deletions(-)
--
2.18.0
From: Zoie Lin <[email protected]>
Incorporate support for the dovdd regulator, which supplies an
additional power source to the EEPROM.
Signed-off-by: Zoie Lin <[email protected]>
---
drivers/misc/eeprom/at24.c | 37 +++++++++++++++++++++++++++++++++++--
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 572333ead5fb..b96f6eda3ad2 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -86,6 +86,7 @@ struct at24_data {
struct nvmem_device *nvmem;
struct regulator *vcc_reg;
+ struct regulator *dovdd_reg;
void (*read_post)(unsigned int off, char *buf, size_t count);
/*
@@ -697,6 +698,14 @@ static int at24_probe(struct i2c_client *client)
if (IS_ERR(at24->vcc_reg))
return PTR_ERR(at24->vcc_reg);
+ at24->dovdd_reg = devm_regulator_get_optional(dev, "dovdd");
+ if (IS_ERR(at24->dovdd_reg)) {
+ if (PTR_ERR(at24->dovdd_reg) == -ENODEV)
+ at24->dovdd_reg = NULL;
+ else
+ return PTR_ERR(at24->dovdd_reg);
+ }
+
writable = !(flags & AT24_FLAG_READONLY);
if (writable) {
at24->write_max = min_t(unsigned int,
@@ -754,6 +763,14 @@ static int at24_probe(struct i2c_client *client)
return err;
}
+ if (at24->dovdd_reg != NULL) {
+ err = regulator_enable(at24->dovdd_reg);
+ if (err) {
+ dev_err(dev, "Failed to enable dovdd regulator\n");
+ return err;
+ }
+ }
+
pm_runtime_set_active(dev);
}
pm_runtime_enable(dev);
@@ -761,8 +778,11 @@ static int at24_probe(struct i2c_client *client)
at24->nvmem = devm_nvmem_register(dev, &nvmem_config);
if (IS_ERR(at24->nvmem)) {
pm_runtime_disable(dev);
- if (!pm_runtime_status_suspended(dev))
+ if (!pm_runtime_status_suspended(dev)) {
regulator_disable(at24->vcc_reg);
+ if (at24->dovdd_reg != NULL)
+ regulator_disable(at24->dovdd_reg);
+ }
return dev_err_probe(dev, PTR_ERR(at24->nvmem),
"failed to register nvmem\n");
}
@@ -804,8 +824,11 @@ static void at24_remove(struct i2c_client *client)
pm_runtime_disable(&client->dev);
if (acpi_dev_state_d0(&client->dev)) {
- if (!pm_runtime_status_suspended(&client->dev))
+ if (!pm_runtime_status_suspended(&client->dev)) {
regulator_disable(at24->vcc_reg);
+ if (at24->dovdd_reg != NULL)
+ regulator_disable(at24->dovdd_reg);
+ }
pm_runtime_set_suspended(&client->dev);
}
}
@@ -815,14 +838,24 @@ static int __maybe_unused at24_suspend(struct device *dev)
struct i2c_client *client = to_i2c_client(dev);
struct at24_data *at24 = i2c_get_clientdata(client);
+ if (at24->dovdd_reg != NULL)
+ regulator_disable(at24->dovdd_reg);
+
return regulator_disable(at24->vcc_reg);
}
static int __maybe_unused at24_resume(struct device *dev)
{
+ int err;
struct i2c_client *client = to_i2c_client(dev);
struct at24_data *at24 = i2c_get_clientdata(client);
+ if (at24->dovdd_reg != NULL) {
+ err = regulator_enable(at24->dovdd_reg);
+ if (err)
+ return err;
+ }
+
return regulator_enable(at24->vcc_reg);
}
--
2.18.0
From: Zoie Lin <[email protected]>
Include a new property named dovdd-supply to provide an
additional power supply.
Signed-off-by: Zoie Lin <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 8befd09963be..0ecb7ea76d1d 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -193,6 +193,10 @@ properties:
description:
phandle of the regulator that provides the supply voltage.
+ dovdd-supply:
+ description:
+ phandle of the regulator that provides the supply voltage.
+
required:
- compatible
- reg
--
2.18.0
From: Zoie Lin <[email protected]>
Update EEPROM bindings to include Atmel AT24C64
Signed-off-by: Zoie Lin <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 1812ef31d5f1..8befd09963be 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -131,6 +131,8 @@ properties:
- items:
- const: giantec,gt24c32a
- const: atmel,24c32
+ - items:
+ - const: atmel,24c64
- items:
- enum:
- renesas,r1ex24128
--
2.18.0
On 26/04/2024 12:29, zoie.lin wrote:
> From: Zoie Lin <[email protected]>
>
> Update EEPROM bindings to include Atmel AT24C64
>
> Signed-off-by: Zoie Lin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 1812ef31d5f1..8befd09963be 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -131,6 +131,8 @@ properties:
> - items:
> - const: giantec,gt24c32a
> - const: atmel,24c32
> + - items:
> + - const: atmel,24c64
It is already there as part of pattern. Did you look at it?
Best regards,
Krzysztof
On 26/04/2024 12:29, zoie.lin wrote:
> From: Zoie Lin <[email protected]>
>
> Include a new property named dovdd-supply to provide an
> additional power supply.
Which pin is it? Which device? Please write something useful...
I cannot find such pin on AT24C64, which you are adding support here.
https://ww1.microchip.com/downloads/en/devicedoc/doc0336.pdf
Best regards,
Krzysztof
On Fri, 26 Apr 2024 18:29:48 +0800, zoie.lin wrote:
> From: Zoie Lin <[email protected]>
>
> Update EEPROM bindings to include Atmel AT24C64
>
> Signed-off-by: Zoie Lin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: idt@74: eeprom@50:compatible: More than one condition true in oneOf schema:
{'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'},
{'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
{'oneOf': [{'items': {'pattern': 'c00$'},
'type': 'array'},
{'items': {'pattern': 'c01$'},
'type': 'array'},
{'items': {'pattern': 'cs01$'},
'type': 'array'},
{'items': {'pattern': 'c02$'},
'type': 'array'},
{'items': {'pattern': 'cs02$'},
'type': 'array'},
{'items': {'pattern': 'mac402$'},
'type': 'array'},
{'items': {'pattern': 'mac602$'},
'type': 'array'},
{'items': {'pattern': 'c04$'},
'type': 'array'},
{'items': {'pattern': 'cs04$'},
'type': 'array'},
{'items': {'pattern': 'c08$'},
'type': 'array'},
{'items': {'pattern': 'cs08$'},
'type': 'array'},
{'items': {'pattern': 'c16$'},
'type': 'array'},
{'items': {'pattern': 'cs16$'},
'type': 'array'},
{'items': {'pattern': 'c32$'},
'type': 'array'},
{'items': {'pattern': 'c32d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs32$'},
'type': 'array'},
{'items': {'pattern': 'c64$'},
'type': 'array'},
{'items': {'pattern': 'c64d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs64$'},
'type': 'array'},
{'items': {'pattern': 'c128$'},
'type': 'array'},
{'items': {'pattern': 'cs128$'},
'type': 'array'},
{'items': {'pattern': 'c256$'},
'type': 'array'},
{'items': {'pattern': 'cs256$'},
'type': 'array'},
{'items': {'pattern': 'c512$'},
'type': 'array'},
{'items': {'pattern': 'cs512$'},
'type': 'array'},
{'items': {'pattern': 'c1024$'},
'type': 'array'},
{'items': {'pattern': 'cs1024$'},
'type': 'array'},
{'items': {'pattern': 'c1025$'},
'type': 'array'},
{'items': {'pattern': 'cs1025$'},
'type': 'array'},
{'items': {'pattern': 'c2048$'},
'type': 'array'},
{'items': {'pattern': 'cs2048$'},
'type': 'array'},
{'items': {'pattern': 'spd$'},
'type': 'array'}]}]},
{'items': [{'const': 'belling,bl24c16a'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']},
{'const': 'atmel,24c01'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']},
{'const': 'atmel,24c02'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['onnn,cat24c04',
'onnn,cat24c05',
'rohm,br24g04']},
{'const': 'atmel,24c04'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'renesas,r1ex24016'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'giantec,gt24c32a'},
{'const': 'atmel,24c32'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'atmel,24c64'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'items': [{'enum': ['renesas,r1ex24128',
'samsung,s524ad0xd1']},
{'const': 'atmel,24c128'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]}
from schema $id: http://devicetree.org/schemas/misc/idt,89hpesx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: idt@74: eeprom@50: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/misc/idt,89hpesx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: eeprom@50: compatible: More than one condition true in oneOf schema:
{'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'},
{'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
{'oneOf': [{'items': {'pattern': 'c00$'},
'type': 'array'},
{'items': {'pattern': 'c01$'},
'type': 'array'},
{'items': {'pattern': 'cs01$'},
'type': 'array'},
{'items': {'pattern': 'c02$'},
'type': 'array'},
{'items': {'pattern': 'cs02$'},
'type': 'array'},
{'items': {'pattern': 'mac402$'},
'type': 'array'},
{'items': {'pattern': 'mac602$'},
'type': 'array'},
{'items': {'pattern': 'c04$'},
'type': 'array'},
{'items': {'pattern': 'cs04$'},
'type': 'array'},
{'items': {'pattern': 'c08$'},
'type': 'array'},
{'items': {'pattern': 'cs08$'},
'type': 'array'},
{'items': {'pattern': 'c16$'},
'type': 'array'},
{'items': {'pattern': 'cs16$'},
'type': 'array'},
{'items': {'pattern': 'c32$'},
'type': 'array'},
{'items': {'pattern': 'c32d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs32$'},
'type': 'array'},
{'items': {'pattern': 'c64$'},
'type': 'array'},
{'items': {'pattern': 'c64d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs64$'},
'type': 'array'},
{'items': {'pattern': 'c128$'},
'type': 'array'},
{'items': {'pattern': 'cs128$'},
'type': 'array'},
{'items': {'pattern': 'c256$'},
'type': 'array'},
{'items': {'pattern': 'cs256$'},
'type': 'array'},
{'items': {'pattern': 'c512$'},
'type': 'array'},
{'items': {'pattern': 'cs512$'},
'type': 'array'},
{'items': {'pattern': 'c1024$'},
'type': 'array'},
{'items': {'pattern': 'cs1024$'},
'type': 'array'},
{'items': {'pattern': 'c1025$'},
'type': 'array'},
{'items': {'pattern': 'cs1025$'},
'type': 'array'},
{'items': {'pattern': 'c2048$'},
'type': 'array'},
{'items': {'pattern': 'cs2048$'},
'type': 'array'},
{'items': {'pattern': 'spd$'},
'type': 'array'}]}]},
{'items': [{'const': 'belling,bl24c16a'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']},
{'const': 'atmel,24c01'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']},
{'const': 'atmel,24c02'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['onnn,cat24c04',
'onnn,cat24c05',
'rohm,br24g04']},
{'const': 'atmel,24c04'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'renesas,r1ex24016'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'giantec,gt24c32a'},
{'const': 'atmel,24c32'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'atmel,24c64'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'items': [{'enum': ['renesas,r1ex24128',
'samsung,s524ad0xd1']},
{'const': 'atmel,24c128'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]}
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: eeprom@50: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb: eeprom@56: compatible: More than one condition true in oneOf schema:
{'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'},
{'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
{'oneOf': [{'items': {'pattern': 'c00$'},
'type': 'array'},
{'items': {'pattern': 'c01$'},
'type': 'array'},
{'items': {'pattern': 'cs01$'},
'type': 'array'},
{'items': {'pattern': 'c02$'},
'type': 'array'},
{'items': {'pattern': 'cs02$'},
'type': 'array'},
{'items': {'pattern': 'mac402$'},
'type': 'array'},
{'items': {'pattern': 'mac602$'},
'type': 'array'},
{'items': {'pattern': 'c04$'},
'type': 'array'},
{'items': {'pattern': 'cs04$'},
'type': 'array'},
{'items': {'pattern': 'c08$'},
'type': 'array'},
{'items': {'pattern': 'cs08$'},
'type': 'array'},
{'items': {'pattern': 'c16$'},
'type': 'array'},
{'items': {'pattern': 'cs16$'},
'type': 'array'},
{'items': {'pattern': 'c32$'},
'type': 'array'},
{'items': {'pattern': 'c32d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs32$'},
'type': 'array'},
{'items': {'pattern': 'c64$'},
'type': 'array'},
{'items': {'pattern': 'c64d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs64$'},
'type': 'array'},
{'items': {'pattern': 'c128$'},
'type': 'array'},
{'items': {'pattern': 'cs128$'},
'type': 'array'},
{'items': {'pattern': 'c256$'},
'type': 'array'},
{'items': {'pattern': 'cs256$'},
'type': 'array'},
{'items': {'pattern': 'c512$'},
'type': 'array'},
{'items': {'pattern': 'cs512$'},
'type': 'array'},
{'items': {'pattern': 'c1024$'},
'type': 'array'},
{'items': {'pattern': 'cs1024$'},
'type': 'array'},
{'items': {'pattern': 'c1025$'},
'type': 'array'},
{'items': {'pattern': 'cs1025$'},
'type': 'array'},
{'items': {'pattern': 'c2048$'},
'type': 'array'},
{'items': {'pattern': 'cs2048$'},
'type': 'array'},
{'items': {'pattern': 'spd$'},
'type': 'array'}]}]},
{'items': [{'const': 'belling,bl24c16a'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']},
{'const': 'atmel,24c01'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']},
{'const': 'atmel,24c02'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['onnn,cat24c04',
'onnn,cat24c05',
'rohm,br24g04']},
{'const': 'atmel,24c04'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'renesas,r1ex24016'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'giantec,gt24c32a'},
{'const': 'atmel,24c32'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'atmel,24c64'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'items': [{'enum': ['renesas,r1ex24128',
'samsung,s524ad0xd1']},
{'const': 'atmel,24c128'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]}
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb: eeprom@56: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
On Fri, Apr 26, 2024 at 06:29:49PM +0800, zoie.lin wrote:
> From: Zoie Lin <[email protected]>
>
> Include a new property named dovdd-supply to provide an
> additional power supply.
>
> Signed-off-by: Zoie Lin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 8befd09963be..0ecb7ea76d1d 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -193,6 +193,10 @@ properties:
> description:
> phandle of the regulator that provides the supply voltage.
>
> + dovdd-supply:
> + description:
> + phandle of the regulator that provides the supply voltage.
We already have "the regulator that provides the supply voltage" just
above.
> +
> required:
> - compatible
> - reg
> --
> 2.18.0
>
On Fri, Apr 26, 2024 at 06:29:47PM +0800, zoie.lin wrote:
> From: Zoie Lin <[email protected]>
>
> Incorporate support for the dovdd regulator, which supplies an
> additional power source to the EEPROM.
It would be helpful if you could supply some additional information
about what this supply is, why we can't tell if it's supposed to be
there or not and so on.