2024-04-30 06:03:59

by Krzysztof Kozlowski

Subject: [PATCH] pinctrl: samsung: drop redundant drvdata assignment

Fix W=1 warning:

drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpio_set_direction’:
drivers/pinctrl/samsung/pinctrl-samsung.c:633:42: warning: variable ‘drvdata’ set but not used [-Wunused-but-set-variable]

Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index f4607b8493ff..623df65a5d6f 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -630,11 +630,9 @@ static int samsung_gpio_set_direction(struct gpio_chip *gc,
struct samsung_pin_bank *bank;
void __iomem *reg;
u32 data, mask, shift;
- struct samsung_pinctrl_drv_data *drvdata;

bank = gpiochip_get_data(gc);
type = bank->type;
- drvdata = bank->drvdata;

reg = bank->pctl_base + bank->pctl_offset
+ type->reg_offset[PINCFG_TYPE_FUNC];
--
2.43.0

2024-04-30 07:27:57

by André Draszik

Subject: Re: [PATCH] pinctrl: samsung: drop redundant drvdata assignment

On Tue, 2024-04-30 at 08:03 +0200, Krzysztof Kozlowski wrote:
> Fix W=1 warning:
>
>   drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpio_set_direction’:
>   drivers/pinctrl/samsung/pinctrl-samsung.c:633:42: warning: variable ‘drvdata’ set but not used [-Wunused-but-set-variable]
>
> Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: André Draszik <[email protected]>

2024-04-30 07:42:51

by Krzysztof Kozlowski

Subject: Re: [PATCH] pinctrl: samsung: drop redundant drvdata assignment

On Tue, 30 Apr 2024 08:03:04 +0200, Krzysztof Kozlowski wrote:
> Fix W=1 warning:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpio_set_direction’:
> drivers/pinctrl/samsung/pinctrl-samsung.c:633:42: warning: variable ‘drvdata’ set but not used [-Wunused-but-set-variable]
>
>

Applied, thanks!

[1/1] pinctrl: samsung: drop redundant drvdata assignment
https://git.kernel.org/pinctrl/samsung/c/e5b3732a9654f26d21647d9e7b4fec846f6d4810

Best regards,
--
Krzysztof Kozlowski <[email protected]>