2024-05-01 07:53:44

by Johan Hovold

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: qcs404: fix bluetooth device address

The 'local-bd-address' property is used to pass a unique Bluetooth
device address from the boot firmware to the kernel and should otherwise
be left unset so that the OS can prevent the controller from being used
until a valid address has been provided through some other means (e.g.
using btmgmt).

Fixes: 60f77ae7d1c1 ("arm64: dts: qcom: qcs404-evb: Enable uart3 and add Bluetooth")
Cc: [email protected] # 5.10
Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
index 10655401528e..a22b4501ce1e 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
@@ -62,7 +62,7 @@ bluetooth {
vddrf-supply = <&vreg_l1_1p3>;
vddch0-supply = <&vdd_ch0_3p3>;

- local-bd-address = [ 02 00 00 00 5a ad ];
+ local-bd-address = [ 00 00 00 00 00 00 ];

max-speed = <3200000>;
};
--
2.43.2



2024-05-01 10:14:31

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: fix bluetooth device address

On 01/05/2024 08:52, Johan Hovold wrote:
> The 'local-bd-address' property is used to pass a unique Bluetooth
> device address from the boot firmware to the kernel and should otherwise
> be left unset so that the OS can prevent the controller from being used
> until a valid address has been provided through some other means (e.g.
> using btmgmt).
>
> Fixes: 60f77ae7d1c1 ("arm64: dts: qcom: qcs404-evb: Enable uart3 and add Bluetooth")
> Cc: [email protected] # 5.10
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 10655401528e..a22b4501ce1e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -62,7 +62,7 @@ bluetooth {
> vddrf-supply = <&vreg_l1_1p3>;
> vddch0-supply = <&vdd_ch0_3p3>;
>
> - local-bd-address = [ 02 00 00 00 5a ad ];
> + local-bd-address = [ 00 00 00 00 00 00 ];
>
> max-speed = <3200000>;
> };

Reviewed-by: Bryan O'Donoghue <[email protected]>

2024-05-01 20:21:41

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: fix bluetooth device address


On Wed, 01 May 2024 09:52:01 +0200, Johan Hovold wrote:
> The 'local-bd-address' property is used to pass a unique Bluetooth
> device address from the boot firmware to the kernel and should otherwise
> be left unset so that the OS can prevent the controller from being used
> until a valid address has been provided through some other means (e.g.
> using btmgmt).
>
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: qcs404: fix bluetooth device address
commit: f5f390a77f18eaeb2c93211a1b7c5e66b5acd423

Best regards,
--
Bjorn Andersson <[email protected]>