From: "Dr. David Alan Gilbert" <[email protected]>
The list 'claimed_sram' seems unused, as far as I can tell it always
has been.
I think the 'list' member of sunxi_sram_data was intended to be
used when it was on that list.
Remove them.
Build tested only.
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/soc/sunxi/sunxi_sram.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 6eb6cf06278e6..71cc377b5e243 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -33,7 +33,6 @@ struct sunxi_sram_data {
u8 offset;
u8 width;
struct sunxi_sram_func *func;
- struct list_head list;
};
struct sunxi_sram_desc {
@@ -103,7 +102,6 @@ static const struct of_device_id sunxi_sram_dt_ids[] = {
};
static struct device *sram_dev;
-static LIST_HEAD(claimed_sram);
static DEFINE_SPINLOCK(sram_lock);
static void __iomem *base;
--
2.45.0
* [email protected] ([email protected]) wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> The list 'claimed_sram' seems unused, as far as I can tell it always
> has been.
> I think the 'list' member of sunxi_sram_data was intended to be
> used when it was on that list.
> Remove them.
>
> Build tested only.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Ping
> ---
> drivers/soc/sunxi/sunxi_sram.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 6eb6cf06278e6..71cc377b5e243 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -33,7 +33,6 @@ struct sunxi_sram_data {
> u8 offset;
> u8 width;
> struct sunxi_sram_func *func;
> - struct list_head list;
> };
>
> struct sunxi_sram_desc {
> @@ -103,7 +102,6 @@ static const struct of_device_id sunxi_sram_dt_ids[] = {
> };
>
> static struct device *sram_dev;
> -static LIST_HEAD(claimed_sram);
> static DEFINE_SPINLOCK(sram_lock);
> static void __iomem *base;
>
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
On Sat, 04 May 2024 21:44:01 +0100, [email protected] wrote:
> The list 'claimed_sram' seems unused, as far as I can tell it always
> has been.
> I think the 'list' member of sunxi_sram_data was intended to be
> used when it was on that list.
> Remove them.
>
> Build tested only.
>
> [...]
Applied to sunxi/drivers-for-6.11 in sunxi/linux.git, thanks!
[1/1] soc: sunxi: sram: Remove unused list 'claimed_sram'
https://git.kernel.org/sunxi/linux/c/a40cf069ac61
Best regards,
--
Chen-Yu Tsai <[email protected]>