2024-05-28 21:31:22

by Tristram.Ha

Subject: [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver

From: Tristram Ha <[email protected]>

The driver should return RMII interface when XMII is running in RMII mode.

Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
Signed-off-by: Tristram Ha <[email protected]>
Acked-by: Arun Ramadoss <[email protected]>
Acked-by: Jerry Ray <[email protected]>
---
drivers/net/dsa/microchip/ksz_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 1e0085cd9a9a..2818e24e2a51 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3142,7 +3142,7 @@ phy_interface_t ksz_get_xmii(struct ksz_device *dev, int port, bool gbit)
else
interface = PHY_INTERFACE_MODE_MII;
} else if (val == bitval[P_RMII_SEL]) {
- interface = PHY_INTERFACE_MODE_RGMII;
+ interface = PHY_INTERFACE_MODE_RMII;
} else {
interface = PHY_INTERFACE_MODE_RGMII;
if (data8 & P_RGMII_ID_EG_ENABLE)
--
2.34.1

2024-05-29 00:59:04

by Andrew Lunn

Subject: Re: [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver

On Tue, May 28, 2024 at 02:34:26PM -0700, [email protected] wrote:
> From: Tristram Ha <[email protected]>
>
> The driver should return RMII interface when XMII is running in RMII mode.
>
> Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
> Signed-off-by: Tristram Ha <[email protected]>
> Acked-by: Arun Ramadoss <[email protected]>
> Acked-by: Jerry Ray <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2024-05-30 02:01:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 28 May 2024 14:34:26 -0700 you wrote:
> From: Tristram Ha <[email protected]>
>
> The driver should return RMII interface when XMII is running in RMII mode.
>
> Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
> Signed-off-by: Tristram Ha <[email protected]>
> Acked-by: Arun Ramadoss <[email protected]>
> Acked-by: Jerry Ray <[email protected]>
>
> [...]

Here is the summary with links:
- [net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
https://git.kernel.org/netdev/net/c/278d65ccdadb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html