2024-05-30 11:52:00

by Andy Shevchenko

Subject: [PATCH v1 1/1] mfd: core: Make use of device_set_node()

Use device_set_node() instead of assigning pdev->dev.of_node
directly because it also sets the firmware node.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mfd/mfd-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 6ad5c93027af..7ea9a875d8f3 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -87,7 +87,7 @@ static void mfd_acpi_add_device(const struct mfd_cell *cell,
}
}

- ACPI_COMPANION_SET(&pdev->dev, adev ?: parent);
+ device_set_node(&pdev->dev, acpi_fwnode_handle(adev ?: parent));
}
#else
static inline void mfd_acpi_add_device(const struct mfd_cell *cell,
@@ -131,8 +131,7 @@ static int mfd_match_of_node_to_dev(struct platform_device *pdev,
of_entry->np = np;
list_add_tail(&of_entry->list, &mfd_of_node_list);

- pdev->dev.of_node = np;
- pdev->dev.fwnode = &np->fwnode;
+ device_set_node(&pdev->dev, of_fwnode_handle(np));
#endif
return 0;
}
--
2.43.0.rc1.1336.g36b5255a03ac

2024-05-31 07:39:20

by Herve Codina

Subject: Re: [PATCH v1 1/1] mfd: core: Make use of device_set_node()

Hi Andy,

On Thu, 30 May 2024 14:51:47 +0300
Andy Shevchenko <[email protected]> wrote:

> Use device_set_node() instead of assigning pdev->dev.of_node
> directly because it also sets the firmware node.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Herve Codina <[email protected]>

Best regards,
Hervé

2024-05-31 17:06:19

by Lee Jones

Subject: Re: (subset) [PATCH v1 1/1] mfd: core: Make use of device_set_node()

On Thu, 30 May 2024 14:51:47 +0300, Andy Shevchenko wrote:
> Use device_set_node() instead of assigning pdev->dev.of_node
> directly because it also sets the firmware node.
>
>

Applied, thanks!

[1/1] mfd: core: Make use of device_set_node()
commit: 03ab12796acff74d1c0e8278569499f989134377

--
Lee Jones [李琼斯]