2024-05-31 21:16:08

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH v1] tools api io: Move filling the io buffer to its own function

On Sun, 19 May 2024 11:17:16 -0700, Ian Rogers wrote:
> In general a read fills 4kb so filling the buffer is a 1 in 4096
> operation, move it out of the io__get_char function to avoid some
> checking overhead and to better hint the function is good to inline.
>
> For perf's IO intensive internal (non-rigorous) benchmarks there's a
> near 8% improvement to kallsyms-parsing with a default build.
>
> [...]

Applied to perf-tools-next, thanks!

Best regards,
--
Namhyung Kim <[email protected]>