Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
to fully document the block and also fix dtbs_check warning:
juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Cc: Jiaxun Yang <[email protected]>
---
.../bindings/arm/arm,juno-fpga-apb-regs.yaml | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/arm,juno-fpga-apb-regs.yaml
diff --git a/Documentation/devicetree/bindings/arm/arm,juno-fpga-apb-regs.yaml b/Documentation/devicetree/bindings/arm/arm,juno-fpga-apb-regs.yaml
new file mode 100644
index 000000000000..97a7a6281d62
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/arm,juno-fpga-apb-regs.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/arm,juno-fpga-apb-regs.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM Juno FPGA APB Registers
+
+maintainers:
+ - Linus Walleij <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: arm,juno-fpga-apb-regs
+ - const: syscon
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ ranges: true
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+patternProperties:
+ "^led@[0-9a-f]+,[0-9a-f]$":
+ $ref: /schemas/leds/register-bit-led.yaml#
+
+required:
+ - compatible
+ - reg
+ - ranges
+ - "#address-cells"
+ - "#size-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@10000 {
+ compatible = "arm,juno-fpga-apb-regs", "syscon", "simple-mfd";
+ reg = <0x010000 0x1000>;
+ ranges = <0x0 0x10000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ led@8,0 {
+ compatible = "register-bit-led";
+ reg = <0x08 0x04>;
+ offset = <0x08>;
+ mask = <0x01>;
+ label = "vexpress:0";
+ linux,default-trigger = "heartbeat";
+ default-state = "on";
+ };
+ };
--
2.43.0
Each syscon node must come with a dedicated/specific compatible, which
is also reported by dtbs_check:
juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Cc: Jiaxun Yang <[email protected]>
---
arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
index be42932f7e21..6ca73f41408d 100644
--- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
@@ -158,7 +158,8 @@ v2m_sysctl: sysctl@20000 {
};
apbregs@10000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "arm,juno-fpga-apb-regs",
+ "syscon", "simple-mfd";
reg = <0x010000 0x1000>;
ranges = <0x0 0x10000 0x1000>;
#address-cells = <1>;
--
2.43.0
On Sat, May 18, 2024 at 10:39:02PM +0200, Krzysztof Kozlowski wrote:
> Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
> to fully document the block and also fix dtbs_check warning:
>
> juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
Cheers,
Conor.
On Sat, May 18, 2024 at 10:39 PM Krzysztof Kozlowski
<[email protected]> wrote:
> Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
> to fully document the block and also fix dtbs_check warning:
>
> juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
(...)
> +maintainers:
> + - Linus Walleij <[email protected]>
This feels more like a Sudeep area of responsibility than
mine, so please use:
Sudeep Holla <[email protected]>
Yours,
Linus Walleij
On Tue, May 28, 2024 at 01:47:33PM +0200, Linus Walleij wrote:
> On Sat, May 18, 2024 at 10:39 PM Krzysztof Kozlowski
> <[email protected]> wrote:
>
> > Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
> > to fully document the block and also fix dtbs_check warning:
> >
> > juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> (...)
> > +maintainers:
> > + - Linus Walleij <[email protected]>
>
> This feels more like a Sudeep area of responsibility than
> mine, so please use:
> Sudeep Holla <[email protected]>
>
Indeed, I queued them a week before -rc1 and was away last week. I plan to
rebase and reply after applying them officially ????
--
Regards,
Sudeep
On Sat, 18 May 2024 22:39:02 +0200, Krzysztof Kozlowski wrote:
> Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
> to fully document the block and also fix dtbs_check warning:
>
> juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
Applied to sudeep.holla/linux (for-next/vexpress/updates), thanks!
[1/2] dt-bindings: arm: arm,juno-fpga-apb-regs: document FPGA syscon
https://git.kernel.org/sudeep.holla/c/3e295d8b4731
[2/2] arm64: dts: juno: add dedicated FPGA syscon compatible
https://git.kernel.org/sudeep.holla/c/2e84e7ed7b02
--
Regards,
Sudeep
On 03/06/2024 14:51, Sudeep Holla wrote:
> On Sat, 18 May 2024 22:39:02 +0200, Krzysztof Kozlowski wrote:
>> Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
>> to fully document the block and also fix dtbs_check warning:
>>
>> juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
>
> Applied to sudeep.holla/linux (for-next/vexpress/updates), thanks!
>
> [1/2] dt-bindings: arm: arm,juno-fpga-apb-regs: document FPGA syscon
> https://git.kernel.org/sudeep.holla/c/3e295d8b4731
> [2/2] arm64: dts: juno: add dedicated FPGA syscon compatible
> https://git.kernel.org/sudeep.holla/c/2e84e7ed7b02
Thanks. It seems your tree is not in the linux-next or this branch is
not in next, because these patches are not available in next after a
week. Maybe you need to update the branches being fed to next (including
pending-fixes etc.).
Best regards,
Krzysztof
On Wed, Jun 12, 2024 at 11:13:32AM +0200, Krzysztof Kozlowski wrote:
> On 03/06/2024 14:51, Sudeep Holla wrote:
> > On Sat, 18 May 2024 22:39:02 +0200, Krzysztof Kozlowski wrote:
> >> Add dedicated bindings for the FPGA syscon registers on ARM Juno board,
> >> to fully document the block and also fix dtbs_check warning:
> >>
> >> juno.dtb: apbregs@10000: compatible: ['syscon', 'simple-mfd'] is too short
> >
> > Applied to sudeep.holla/linux (for-next/vexpress/updates), thanks!
> >
> > [1/2] dt-bindings: arm: arm,juno-fpga-apb-regs: document FPGA syscon
> > https://git.kernel.org/sudeep.holla/c/3e295d8b4731
> > [2/2] arm64: dts: juno: add dedicated FPGA syscon compatible
> > https://git.kernel.org/sudeep.holla/c/2e84e7ed7b02
>
> Thanks. It seems your tree is not in the linux-next or this branch is
> not in next, because these patches are not available in next after a
> week. Maybe you need to update the branches being fed to next (including
> pending-fixes etc.).
>
Done now. It is just that I missed to push the updates to my for-linux-next.
I got it ready when I responded to this thread and forgot to push. I didn't
queue anything after that and completely lost track ????.
--
Regards,
Sudeep