2024-05-29 12:47:40

by Thorsten Blum

Subject: [PATCH] bpf, devmap: Remove unnecessary if check in for loop

The iterator variable dst cannot be NULL and the if check can be
removed.

Remove it and fix the following Coccinelle/coccicheck warning reported
by itnull.cocci:

ERROR: iterator variable bound on line 762 cannot be NULL

Signed-off-by: Thorsten Blum <[email protected]>
---
kernel/bpf/devmap.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index 4e2cdbb5629f..7f3b34452243 100644
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -760,9 +760,6 @@ int dev_map_redirect_multi(struct net_device *dev, struct sk_buff *skb,
for (i = 0; i < dtab->n_buckets; i++) {
head = dev_map_index_hash(dtab, i);
hlist_for_each_entry_safe(dst, next, head, index_hlist) {
- if (!dst)
- continue;
-
if (is_ifindex_excluded(excluded_devices, num_excluded,
dst->dev->ifindex))
continue;
--
2.45.1

2024-05-29 14:41:03

by Toke Høiland-Jørgensen

Subject: Re: [PATCH] bpf, devmap: Remove unnecessary if check in for loop

Thorsten Blum <[email protected]> writes:

> The iterator variable dst cannot be NULL and the if check can be
> removed.
>
> Remove it and fix the following Coccinelle/coccicheck warning reported
> by itnull.cocci:
>
> ERROR: iterator variable bound on line 762 cannot be NULL
>
> Signed-off-by: Thorsten Blum <[email protected]>

Reviewed-by: Toke Høiland-Jørgensen <[email protected]>

2024-06-03 15:10:55

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] bpf, devmap: Remove unnecessary if check in for loop

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <[email protected]>:

On Wed, 29 May 2024 12:19:01 +0200 you wrote:
> The iterator variable dst cannot be NULL and the if check can be
> removed.
>
> Remove it and fix the following Coccinelle/coccicheck warning reported
> by itnull.cocci:
>
> ERROR: iterator variable bound on line 762 cannot be NULL
>
> [...]

Here is the summary with links:
- bpf, devmap: Remove unnecessary if check in for loop
https://git.kernel.org/bpf/bpf/c/2317dc2c22cc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html